Bug 100319

Summary: Fix image orientation regression on mac, turn on exif-based rotation in image documents for chromium
Product: WebKit Reporter: Nico Weber <thakis>
Component: ImagesAssignee: Nico Weber <thakis>
Status: RESOLVED WONTFIX    
Severity: Normal CC: eric, senorblanco, thorton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100191    
Attachments:
Description Flags
Patch
none
Patch none

Nico Weber
Reported 2012-10-24 19:37:32 PDT
Fix image orientation regression on mac, turn on exif-based rotation in image documents for chromium
Attachments
Patch (11.72 KB, patch)
2012-10-24 19:42 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (11.80 KB, patch)
2012-10-25 06:46 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-10-24 19:42:09 PDT
Created attachment 170539 [details] Patch
Nico Weber
Comment 2 2012-10-24 19:48:44 PDT
Pasting from irc: if x and y are 0, it's the same as previously, and otherwise it's always adding what's missing for a identity matrix (e.g. "-1 0 0 -1" gets a +2x, +2y because that's missing to get "1 0 0 1", "0 1 1 0" gets +x-y, -y+x" to get "1 0 0 1" etc)
Eric Seidel (no email)
Comment 3 2012-10-24 22:16:17 PDT
Comment on attachment 170539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170539&action=review > Source/WebCore/platform/graphics/ImageOrientation.cpp:35 > +AffineTransform ImageOrientation::transformFromDefault(const FloatRect& drawnRect) const Confused. Why were changes necessary here? Please explain in the ChangeLog. :)
Nico Weber
Comment 4 2012-10-24 22:44:39 PDT
Comment on attachment 170539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170539&action=review >> Source/WebCore/platform/graphics/ImageOrientation.cpp:35 >> +AffineTransform ImageOrientation::transformFromDefault(const FloatRect& drawnRect) const > > Confused. Why were changes necessary here? Please explain in the ChangeLog. :) I tried to explain in the changelog. Before r132384, the images were always drawn at the origin (i.e. x = y = 0). In the chromium port, and after r132384 in the apple port too, that not true, so this function needs to be updated to handle arbitrary origins. You'll note that when you set x = y = 0 in the formulas below, you get the old formulas back.
Nico Weber
Comment 5 2012-10-25 06:46:41 PDT
Created attachment 170632 [details] Patch
Nico Weber
Comment 6 2012-10-25 12:13:11 PDT
It sounds like people prefer the alternative fix approach in bug https://bugs.webkit.org/show_bug.cgi?id=100401 . If that gets landed, the bug here becomes WontFix.
Nico Weber
Comment 7 2012-10-25 14:19:09 PDT
https://bugs.webkit.org/show_bug.cgi?id=100401 landed. There's https://bugs.webkit.org/show_bug.cgi?id=100414 to switch ImageOrientation to rhs coordinates, which would have the same effect as this patch.
Note You need to log in before you can comment on or make changes to this bug.