Bug 100765

Summary: [CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusionShape
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, giles_joplin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch none

Bem Jones-Bey
Reported 2012-10-30 09:23:13 PDT
It doesn't really make sense for createExclusionShape to return null. It would be more with WebKit style to ensure that it need gets passed a null shape and have it ASSERT that the shape is not null. See comments on bug 100398 for the genesis of this bug.
Attachments
Patch (1.64 KB, patch)
2012-11-15 16:44 PST, Hans Muller 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2012-11-16 09:32 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2012-11-15 16:44:26 PST
Created attachment 174557 [details] Patch ExclusionShape::createExclusionShape now ASSERTs that its basicShape argument isn't null, since the caller is expected to ensure as much.
WebKit Review Bot
Comment 2 2012-11-15 18:07:32 PST
Comment on attachment 174557 [details] Patch Attachment 174557 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14848604 New failing tests: platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html
Hans Muller
Comment 3 2012-11-16 09:32:06 PST
Created attachment 174708 [details] Patch The probability that my small change to createExclusionShape() impacted a WebGL test seems extremely small so I've sync'd with the latest repository and uploaded a new version of the same patch.
WebKit Review Bot
Comment 4 2012-11-19 08:55:32 PST
Comment on attachment 174708 [details] Patch Clearing flags on attachment: 174708 Committed r135166: <http://trac.webkit.org/changeset/135166>
WebKit Review Bot
Comment 5 2012-11-19 08:55:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.