Bug 100782

Summary: [CSS Shaders] Move MeshBoxType out of CustomFilterOperation
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dino, macpherson, menard, mvujovic, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100533    
Attachments:
Description Flags
Patch V1 none

Alexandru Chiculita
Reported 2012-10-30 13:19:28 PDT
We need MeshBoxType for the ValidatedCustomFilterOperation, so extract that to a different file and make it reusable.
Attachments
Patch V1 (17.33 KB, patch)
2012-10-30 14:37 PDT, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1 2012-10-30 14:37:11 PDT
Created attachment 171521 [details] Patch V1
Max Vujovic
Comment 2 2012-10-30 14:52:08 PDT
Comment on attachment 171521 [details] Patch V1 Thanks for doing this, Alex. I was meaning to do it myself. The patch looks good. View in context: https://bugs.webkit.org/attachment.cgi?id=171521&action=review > Source/WebCore/platform/graphics/filters/CustomFilterArrayParameter.h:34 > +#include "AnimationUtilities.h" What's this include for?
Alexandru Chiculita
Comment 3 2012-10-31 14:18:16 PDT
(In reply to comment #2) > (From update of attachment 171521 [details]) > Thanks for doing this, Alex. I was meaning to do it myself. The patch looks good. > > View in context: https://bugs.webkit.org/attachment.cgi?id=171521&action=review > > > Source/WebCore/platform/graphics/filters/CustomFilterArrayParameter.h:34 > > +#include "AnimationUtilities.h" > > What's this include for? WebCore::blend is defined there. We need to move the CustomFilterParameters::blend functions to CPP files.
Max Vujovic
Comment 4 2012-10-31 16:33:24 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 171521 [details] [details]) > > Thanks for doing this, Alex. I was meaning to do it myself. The patch looks good. > > > > View in context: https://bugs.webkit.org/attachment.cgi?id=171521&action=review > > > > > Source/WebCore/platform/graphics/filters/CustomFilterArrayParameter.h:34 > > > +#include "AnimationUtilities.h" > > > > What's this include for? > > WebCore::blend is defined there. We need to move the CustomFilterParameters::blend functions to CPP files. Ah okay. I just noticed you already said this in your ChangeLog- oops :). Patch looks good to me.
Dean Jackson
Comment 5 2012-11-01 14:36:20 PDT
Comment on attachment 171521 [details] Patch V1 rs=me
WebKit Review Bot
Comment 6 2012-11-01 14:48:34 PDT
Comment on attachment 171521 [details] Patch V1 Clearing flags on attachment: 171521 Committed r133227: <http://trac.webkit.org/changeset/133227>
WebKit Review Bot
Comment 7 2012-11-01 14:48:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.