Bug 100976
| Summary: | [CSS Exclusions] Refactor ExclusionShapeInsideInfo to support shape outside & shape inside | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Bear Travis <betravis> |
| Component: | CSS | Assignee: | Bear Travis <betravis> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Bear Travis
With shape outside on floats (bug 100398) it's become necessary to store shape info for both shape outside and shape inside.
Some suggestions for the patch:
computeShapeSize & m_shape can be lazily evaluated to avoid the m_shape asserts.
Names should be shorter, where possible.
The map add currently allocates a block every time when it doesn't need to.
The shape removal code may fail because a style has already been changed. Remove the test to make sure the shape is always removed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Bear Travis
This was already fixed as part of the work on bug 100766.
*** This bug has been marked as a duplicate of bug 100766 ***