Bug 101733

Summary: MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, hta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-11-09 02:33:59 PST
MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
Attachments
Patch (5.21 KB, patch)
2012-11-09 02:41 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (5.20 KB, patch)
2012-11-12 06:46 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-11-09 02:41:32 PST
Created attachment 173249 [details] Patch
jochen
Comment 2 2012-11-12 06:30:05 PST
Comment on attachment 173249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review > Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70 > + Vector<String>::iterator it = names.begin(); why don't you put the definition of "it" inside the for ()?
Tommy Widenflycht
Comment 3 2012-11-12 06:38:31 PST
Comment on attachment 173249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review >> Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70 >> + Vector<String>::iterator it = names.begin(); > > why don't you put the definition of "it" inside the for ()? It makes it more readable imho, I guess you prefer it all in one line? Will fix.
Tommy Widenflycht
Comment 4 2012-11-12 06:46:54 PST
Created attachment 173640 [details] Patch
jochen
Comment 5 2012-11-12 06:50:59 PST
Comment on attachment 173640 [details] Patch Looks good, thanks
WebKit Review Bot
Comment 6 2012-11-12 08:35:18 PST
Comment on attachment 173640 [details] Patch Clearing flags on attachment: 173640 Committed r134245: <http://trac.webkit.org/changeset/134245>
WebKit Review Bot
Comment 7 2012-11-12 08:35:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.