Bug 101854

Summary: BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch kling: review+

Dirk Schulze
Reported 2012-11-10 21:12:56 PST
BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with them selfs. A patch on this bug will just concentrate on these three functions. Animation between polygons will follow.
Attachments
Patch (18.30 KB, patch)
2012-11-10 21:27 PST, Dirk Schulze 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2012-11-10 21:27:47 PST
Created attachment 173485 [details] Patch
Dirk Schulze
Comment 2 2012-11-10 21:31:43 PST
s/each self/themselves/ + s/them selfs/themselves/ in the patch locally.
Andreas Kling
Comment 3 2012-11-12 09:27:07 PST
Comment on attachment 173485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173485&action=review r=me with some minor tweaks. > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:131 > + // Other clip-path operations then BasicShapes can not be animated. s/then/than/ > Source/WebCore/rendering/style/BasicShapes.cpp:65 > + return result; We should use "return result.release();" here. > Source/WebCore/rendering/style/BasicShapes.cpp:90 > + return result; Ditto. > Source/WebCore/rendering/style/BasicShapes.cpp:116 > + return result; Ditto.
Dirk Schulze
Comment 4 2012-11-12 20:52:33 PST
Committed r134352: <http://trac.webkit.org/changeset/134352>
Note You need to log in before you can comment on or make changes to this bug.