Bug 103156

Summary:

With composited scrolling, content should only appear behind overlay scrollbars

Product:

WebKit

Reporter:

vollick

Component:

WebCore Misc.

Assignee:

vollick

Status:

NEW

Severity:

Normal

CC:

dglazkov, eric, simon.fraser, skyostil, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

94743

Bug Blocks:

Attachments:

Description	Flags
Patch	buildbot: commit-queue-

vollick

Reported 2012-11-23 11:20:32 PST

We just need to update the clip of the scrolling layer to exclude the scrollbars when they're not overlay scrollbars.

Attachments
Patch (6.10 KB, patch) 2012-11-23 11:25 PST, vollick	buildbot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

vollick

Comment 1 2012-11-23 11:25:11 PST

Created attachment 175830 [details] Patch

Simon Fraser (smfr)

Comment 2 2012-11-23 11:53:18 PST

Comment on attachment 175830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175830&action=review > Source/WebCore/ChangeLog:3 > + With composited scrolling, content should only appear behind overlay scrollbars This title is ambiguous. I think you mean "content should appear behind overlay scrollbars". > Source/WebCore/rendering/RenderLayerBacking.cpp:744 > + FloatSize clipSize = paddingBox.size(); > + if (m_layerForHorizontalScrollbar && !m_owningLayer->horizontalScrollbar()->isOverlayScrollbar()) > + clipSize.setHeight(clipSize.height() - m_layerForHorizontalScrollbar->size().height()); > + if (m_layerForVerticalScrollbar && !m_owningLayer->verticalScrollbar()->isOverlayScrollbar()) > + clipSize.setWidth(clipSize.width() - m_layerForVerticalScrollbar->size().width()); I think we have a "width for scrollbar" method somewhere that takes into account whether they are overlay scrollbars.

Build Bot

Comment 3 2012-11-23 12:15:02 PST

Comment on attachment 175830 [details] Patch Attachment 175830 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14975397 New failing tests: compositing/overflow/clip-composited-content-under-overflow-controls.html

WebKit Review Bot

Comment 4 2012-11-23 14:07:55 PST

Comment on attachment 175830 [details] Patch Attachment 175830 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14937845 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/clip-composited-content-under-overflow-controls.html compositing/overflow/clip-composited-content-under-overflow-controls.html

Note You need to log in before you can comment on or make changes to this bug.