Bug 104139

Summary: [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
Product: WebKit Reporter: Yael <yael>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104251, 137138    
Bug Blocks:    
Attachments:
Description Flags
issue
none
Patch
none
Patch
none
Patch none

Yael
Reported 2012-12-05 10:42:26 PST
The test fast/dom/vertical-scrollbar-in-rtl.html is calling window.resizeTo, which resizes the window and the viewport. When the test ends, the viewport size is 500x500. We do not resize the window back to 800x600, so our gl viewport stays smaller, and that leads to the garbage we occasionally see in fast/regions tests. These tests fail if they run on the same worker as fast/dom/vertical-scrollbar-in-rtl.html . The attached image shows the problem. A patch is coming.
Attachments
issue (22.85 KB, image/png)
2012-12-05 10:44 PST, Yael 		no flags
Details
Patch (1.47 KB, patch)
2012-12-05 10:48 PST, Yael 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2012-12-06 06:05 PST, Yael 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2012-12-06 09:00 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2012-12-05 10:44:14 PST
Created attachment 177793 [details] issue
Yael
Comment 2 2012-12-05 10:45:18 PST
The attachment needs to be downloaded first, in order to see the issue.
Yael
Comment 3 2012-12-05 10:48:55 PST
Created attachment 177794 [details] Patch The attached patch does not solve all the flakiness we currently have in EFL bot, but it helps fixing the issue described in this bug.
Kenneth Rohde Christiansen
Comment 4 2012-12-05 16:53:15 PST
Comment on attachment 177794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177794&action=review > Tools/WebKitTestRunner/TestController.cpp:568 > + // Resize the window to original size. This is needed after calls to window.resizeTo. > + WKRect rect = m_mainWebView->windowFrame(); No test modifies location?
Yael
Comment 5 2012-12-05 17:02:16 PST
(In reply to comment #4) > (From update of attachment 177794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177794&action=review > > > Tools/WebKitTestRunner/TestController.cpp:568 > > + // Resize the window to original size. This is needed after calls to window.resizeTo. > > + WKRect rect = m_mainWebView->windowFrame(); > > No test modifies location? Thank you for the review. As I mentioned above, there are more flaky tests to fix. If tests that move windows are causing flakiness, i will address that too.
WebKit Review Bot
Comment 6 2012-12-06 02:09:23 PST
Comment on attachment 177794 [details] Patch Clearing flags on attachment: 177794 Committed r136825: <http://trac.webkit.org/changeset/136825>
WebKit Review Bot
Comment 7 2012-12-06 02:09:27 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2012-12-06 04:07:38 PST
Re-opened since this is blocked by bug 104251
Csaba Osztrogonác
Comment 9 2012-12-06 04:46:18 PST
(In reply to comment #8) > Re-opened since this is blocked by bug 104251 Rolled out by http://trac.webkit.org/changeset/136830, because it made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test flakey on Qt-WK2 non-pixel bot. x86-64 Linux Qt Release WebKit2 (Amazon EC2) - non-pixel tester bot: - after: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/11517 - before: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/11516 x86-64 Linux Qt Release WebKit2 (Pixel Tests): - after: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/builds/737 - before: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/builds/736
Yael
Comment 10 2012-12-06 06:05:49 PST
Created attachment 178003 [details] Patch Sorry for the regression. This is the same patch, but the resize is only for EFL port. We definitely need that for EFL port.
Kenneth Rohde Christiansen
Comment 11 2012-12-06 06:30:09 PST
Comment on attachment 178003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178003&action=review > Tools/WebKitTestRunner/TestController.cpp:573 > > +#if PLATFORM(EFL) > + // Resize the window to original size. This is needed after calls to window.resizeTo. > + WKRect rect = m_mainWebView->windowFrame(); > + m_mainWebView->setWindowFrame(WKRectMake(rect.origin.x, rect.origin.y, 800, 600)); > +#endif > + > // Reset notification permissions Could you explain why that is not needed for other platforms?
Yael
Comment 12 2012-12-06 06:43:21 PST
(In reply to comment #11) > (From update of attachment 178003 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178003&action=review > > > Tools/WebKitTestRunner/TestController.cpp:573 > > > > +#if PLATFORM(EFL) > > + // Resize the window to original size. This is needed after calls to window.resizeTo. > > + WKRect rect = m_mainWebView->windowFrame(); > > + m_mainWebView->setWindowFrame(WKRectMake(rect.origin.x, rect.origin.y, 800, 600)); > > +#endif > > + > > // Reset notification permissions > > Could you explain why that is not needed for other platforms? I don't know how other platforms deal with this, but I do know that we set the gl viewport to the size of the window, and if the window is not in the correct size, our gl viewport does not cover the screen properly. You can see clearly in the attached image that the top and left parts are left clear/transparent, because they are clipped.
Yael
Comment 13 2012-12-06 06:46:04 PST
(In reply to comment #12) > (In reply to comment #11) > > (From update of attachment 178003 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=178003&action=review > > > > > Tools/WebKitTestRunner/TestController.cpp:573 > > > > > > +#if PLATFORM(EFL) > > > + // Resize the window to original size. This is needed after calls to window.resizeTo. > > > + WKRect rect = m_mainWebView->windowFrame(); > > > + m_mainWebView->setWindowFrame(WKRectMake(rect.origin.x, rect.origin.y, 800, 600)); > > > +#endif > > > + > > > // Reset notification permissions > > > > Could you explain why that is not needed for other platforms? > I don't know how other platforms deal with this, but I do know that we set the gl viewport to the size of the window, and if the window is not in the correct size, our gl viewport does not cover the screen properly. > You can see clearly in the attached image that the top and left parts are left clear/transparent, because they are clipped. I meant top and right, of course :)
Yael
Comment 14 2012-12-06 08:43:25 PST
The difference between EFL and other platforms is that other platforms do not use a real window, but EFL does.
Yael
Comment 15 2012-12-06 09:00:20 PST
Created attachment 178019 [details] Patch Update the comment about why the changes is needed for EFL and not for other ports.
WebKit Review Bot
Comment 16 2012-12-06 09:44:28 PST
Comment on attachment 178019 [details] Patch Clearing flags on attachment: 178019 Committed r136848: <http://trac.webkit.org/changeset/136848>
WebKit Review Bot
Comment 17 2012-12-06 09:44:32 PST
All reviewed patches have been landed. Closing bug.
Yael
Comment 18 2012-12-07 05:36:25 PST
*** Bug 103641 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.