Bug 104252

Summary: Enable CSS3 position offset for CSS Masking.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, koivisto, krit, macpherson, ojan.autocc, ojan, simon.fraser, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch
none
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated none

Alexis Menard (darktears)
Reported 2012-12-06 04:20:35 PST
Enable CSS3 position offset for CSS Masking.
Attachments
Patch (25.92 KB, patch)
2012-12-06 04:55 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated (26.08 KB, patch)
2012-12-07 13:08 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2012-12-06 04:55:55 PST
Created attachment 177994 [details] Patch
WebKit Review Bot
Comment 2 2012-12-06 07:07:02 PST
Comment on attachment 177994 [details] Patch Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15152862 New failing tests: fast/masking/parsing-mask.html
Alexis Menard (darktears)
Comment 3 2012-12-06 07:09:22 PST
(In reply to comment #2) > (From update of attachment 177994 [details]) > Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15152862 > > New failing tests: > fast/masking/parsing-mask.html chromium doesn't enable yet the CSS3 background position, it is tracked here : https://bugs.webkit.org/show_bug.cgi?id=104253
WebKit Review Bot
Comment 4 2012-12-06 07:40:36 PST
Comment on attachment 177994 [details] Patch Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15154906 New failing tests: fast/masking/parsing-mask.html
Dirk Schulze
Comment 5 2012-12-06 15:55:58 PST
(In reply to comment #4) > (From update of attachment 177994 [details]) > Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15154906 > > New failing tests: > fast/masking/parsing-mask.html Can you add the test to the expectatsion list with expecting fail please? I will look at the patch later.
Dirk Schulze
Comment 6 2012-12-06 21:53:49 PST
Comment on attachment 177994 [details] Patch The patch itself looks good to me. Please try to solve the problems with the bots by setting the exception files
Alexis Menard (darktears)
Comment 7 2012-12-07 13:08:31 PST
Created attachment 178261 [details] Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated
Dirk Schulze
Comment 8 2012-12-07 14:38:08 PST
(In reply to comment #7) > Created an attachment (id=178261) [details] > Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated Hm, the bots seem to be pretty unstable on running the tests. Even on background-pos test failed once.
Dirk Schulze
Comment 9 2012-12-07 18:00:37 PST
Comment on attachment 178261 [details] Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated r=me
WebKit Review Bot
Comment 10 2012-12-07 18:34:59 PST
Comment on attachment 178261 [details] Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated Clearing flags on attachment: 178261 Committed r137007: <http://trac.webkit.org/changeset/137007>
WebKit Review Bot
Comment 11 2012-12-07 18:35:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.