Bug 105054

Summary: Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: Tools / TestsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, jamesr, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-12-14 14:21:16 PST
Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
Attachments
Patch (4.23 KB, patch)
2012-12-14 14:21 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.22 KB, patch)
2012-12-17 11:07 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-12-14 14:21:47 PST
Created attachment 179533 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-14 14:27:37 PST
Comment on attachment 179533 [details] Patch LGTM.
jochen
Comment 3 2012-12-14 14:29:39 PST
Comment on attachment 179533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179533&action=review > Tools/DumpRenderTree/chromium/NotificationPresenter.cpp:114 > + WebKit::Platform::current()->callOnMainThread(deferredDisplayDispatch, new WebNotification(notification)); nit. no WebKit:: (here and everywhere)
jochen
Comment 4 2012-12-15 03:08:04 PST
Comment on attachment 179533 [details] Patch Oops, seems I screwed up the flags Please fix the nits before landing
Mark Pilgrim (Google)
Comment 5 2012-12-17 11:07:32 PST
Created attachment 179771 [details] Patch
Mark Pilgrim (Google)
Comment 6 2012-12-17 11:07:51 PST
Comment on attachment 179771 [details] Patch Nits addressed.
Eric Seidel (no email)
Comment 7 2012-12-17 11:10:27 PST
Comment on attachment 179771 [details] Patch LGTM.
WebKit Review Bot
Comment 8 2012-12-17 11:33:31 PST
Comment on attachment 179771 [details] Patch Clearing flags on attachment: 179771 Committed r137926: <http://trac.webkit.org/changeset/137926>
WebKit Review Bot
Comment 9 2012-12-17 11:33:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.