Bug 105326

Summary: [WebGL][EFL][Qt][GTK] Jelly fishes leave trails on webgl canvas.
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: WebGLAssignee: Viatcheslav Ostapenko <ostap73>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, dongseong.hwang, d-r, noam, webkit.review.bot, ys.suh
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104664    
Attachments:
Description Flags
Jelly fishes with trails.
none
Patch
none
Patch none

Viatcheslav Ostapenko
Reported 2012-12-18 10:44:08 PST
Created attachment 179978 [details] Jelly fishes with trails. Page url: http://aleksandarrodic.com/p/jellyfish/ Seems canvas has to be cleared between frames. Picture attached.
Attachments
Jelly fishes with trails. (102.34 KB, image/jpeg)
2012-12-18 10:44 PST, Viatcheslav Ostapenko 		no flags
Details
Patch (4.46 KB, patch)
2012-12-20 19:38 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2012-12-20 20:31 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-12-20 19:02:45 PST
I posted detail info in irrelevant Bug 105325. http://www.khronos.org/registry/webgl/specs/latest/#2.2 WebGL require clearing a drawing buffer after compositing. It's interesting. copied from https://bugs.webkit.org/show_bug.cgi?id=105325#c2
Dongseong Hwang
Comment 2 2012-12-20 19:38:35 PST
Created attachment 180463 [details] Patch
Viatcheslav Ostapenko
Comment 3 2012-12-20 19:48:33 PST
Comment on attachment 180463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121 > + m_context->markLayerComposited(); Why do you put it here still keeping notImplemented() ?
Dongseong Hwang
Comment 4 2012-12-20 20:12:39 PST
Comment on attachment 180463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121 >> + m_context->markLayerComposited(); > > Why do you put it here still keeping notImplemented() ? It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper(). Do you think removing notImplemented() is better?
Noam Rosenthal
Comment 5 2012-12-20 20:15:52 PST
(In reply to comment #4) > (From update of attachment 180463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review > > >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121 > >> + m_context->markLayerComposited(); > > > > Why do you put it here still keeping notImplemented() ? > > It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper(). > Do you think removing notImplemented() is better? I think not adding markLayerComposited there is better. If it's not implemented it's not implemented :)
Dongseong Hwang
Comment 6 2012-12-20 20:30:17 PST
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 180463 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=180463&action=review > > > > >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:121 > > >> + m_context->markLayerComposited(); > > > > > > Why do you put it here still keeping notImplemented() ? > > > > It is because paintToTextureMapper() is not implemented yet. I just put just one of all requirements of paintToTextureMapper(). > > Do you think removing notImplemented() is better? > > I think not adding markLayerComposited there is better. If it's not implemented it's not implemented :) Yeah, I'll post again. :)
Dongseong Hwang
Comment 7 2012-12-20 20:31:52 PST
Created attachment 180469 [details] Patch
Dongseong Hwang
Comment 8 2012-12-20 20:34:48 PST
(In reply to comment #7) > Created an attachment (id=180469) [details] > Patch Thank you for review! noam, I'm not committer yet. could you cq+? :)
WebKit Review Bot
Comment 9 2012-12-20 21:09:58 PST
Comment on attachment 180469 [details] Patch Clearing flags on attachment: 180469 Committed r138346: <http://trac.webkit.org/changeset/138346>
WebKit Review Bot
Comment 10 2012-12-20 21:10:03 PST
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 11 2013-01-10 20:37:59 PST
*** Bug 100920 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.