Bug 105465

Summary: [Chromium] add setIDBFactory method for embedders to call
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-12-19 14:22:19 PST
[Chromium] add setIDBFactory method for embedders to call
Attachments
Patch (2.60 KB, patch)
2012-12-19 14:23 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2012-12-19 14:33 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-12-19 14:23:54 PST
Created attachment 180227 [details] Patch
WebKit Review Bot
Comment 2 2012-12-19 14:26:16 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Darin Fisher (:fishd, Google)
Comment 3 2012-12-19 14:30:07 PST
Comment on attachment 180227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180227&action=review > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:64 > +WebIDBFactory* s_webIDBFactory = 0; nit: make this a static variable. that makes it invisible at link time to other .cpp files, and that means the compiler can generate slightly less code when you access s_webIDBFactory.
Mark Pilgrim (Google)
Comment 4 2012-12-19 14:33:30 PST
Created attachment 180228 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-12-19 14:33:57 PST
Comment on attachment 180228 [details] Patch Nits addressed.
WebKit Review Bot
Comment 6 2012-12-19 21:45:31 PST
Comment on attachment 180228 [details] Patch Clearing flags on attachment: 180228 Committed r138221: <http://trac.webkit.org/changeset/138221>
WebKit Review Bot
Comment 7 2012-12-19 21:45:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.