Bug 105685

Summary: Cleanup perftest* tests and add a test for computing statistics
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, morrita, webkit-bug-importer, webkit.review.bot, zoltan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97510    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2012-12-22 23:52:19 PST
This is a preparation for the bug 97510. We need a test for calculate_statistics, and we need to refactor tests.
Attachments
Patch (82.81 KB, patch)
2012-12-23 00:12 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-12-23 00:12:01 PST
Created attachment 180617 [details] Patch
WebKit Review Bot
Comment 2 2012-12-23 00:14:58 PST
Attachment 180617 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:210: expected 1 blank line, found 0 [pep8/E301] [5] Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:498: [MainTest.test_upload_json.MockFileUploader.__init__] Method should have "self" as first argument [pylint/E0213] [5] Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:503: [MainTest.test_upload_json.MockFileUploader.upload_single_text_file] Method should have "self" as first argument [pylint/E0213] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2013-01-03 18:37:22 PST
Comment on attachment 180617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180617&action=review OK. > Tools/Scripts/webkitpy/performance_tests/perftest.py:215 > + @staticmethod > + def compute_statistics(values): static methods are rarely worth it in python. :( They're just hard to mock.
WebKit Review Bot
Comment 4 2013-01-03 19:47:25 PST
Comment on attachment 180617 [details] Patch Clearing flags on attachment: 180617 Committed r138774: <http://trac.webkit.org/changeset/138774>
WebKit Review Bot
Comment 5 2013-01-03 19:47:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2013-01-04 01:04:33 PST
<rdar://problem/12955988>
Note You need to log in before you can comment on or make changes to this bug.