Bug 106091

Summary: CSP: Blocked 'track' sources should only log once to the console.
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, feature-media-reviews, mkwst+watchlist, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97978    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Mike West
Reported 2013-01-04 06:37:10 PST
CSP: Blocked 'track' sources should only log once to the console.
Attachments
Patch (5.14 KB, patch)
2013-01-04 06:39 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2013-01-04 09:08 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.13 KB, patch)
2013-01-04 10:39 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-01-04 06:39:31 PST
Created attachment 181300 [details] Patch
Build Bot
Comment 2 2013-01-04 07:05:57 PST
Comment on attachment 181300 [details] Patch Attachment 181300 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15705185 New failing tests: fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html http/tests/security/contentSecurityPolicy/media-src-track-block.html fast/sub-pixel/sub-pixel-accumulates-to-layers.html svg/as-image/img-relative-height.html fast/sub-pixel/transformed-iframe-copy-on-scroll.html
Mike West
Comment 3 2013-01-04 07:12:57 PST
Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree.
WebKit Review Bot
Comment 4 2013-01-04 07:46:55 PST
Comment on attachment 181300 [details] Patch Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15706181 New failing tests: http/tests/security/contentSecurityPolicy/media-src-track-block.html
WebKit Review Bot
Comment 5 2013-01-04 08:24:38 PST
Comment on attachment 181300 [details] Patch Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15697184 New failing tests: http/tests/security/contentSecurityPolicy/media-src-track-block.html
Mike West
Comment 6 2013-01-04 09:01:33 PST
(In reply to comment #3) > Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree. Amusing. After updating, now I see the timeout locally too. *sigh*
Mike West
Comment 7 2013-01-04 09:08:27 PST
Created attachment 181309 [details] Patch
Mike West
Comment 8 2013-01-04 09:09:26 PST
http://wkrev.com/138766 changed 'track's behavior slightly; updating the test to match. That takes care of the timeout locally.
Eric Carlson
Comment 9 2013-01-04 09:56:49 PST
Comment on attachment 181309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22 > + track.setAttribute('src', 'resources/track.srt'); WebKit doesn't support srt files so this should really be track.vtt.
Mike West
Comment 10 2013-01-04 10:38:22 PST
(In reply to comment #9) > (From update of attachment 181309 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review > > > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22 > > + track.setAttribute('src', 'resources/track.srt'); > > WebKit doesn't support srt files so this should really be track.vtt. Got it. I'll spin a new patch and CQ it. Thanks!
Mike West
Comment 11 2013-01-04 10:39:36 PST
Created attachment 181329 [details] Patch for landing
WebKit Review Bot
Comment 12 2013-01-04 11:34:15 PST
Comment on attachment 181329 [details] Patch for landing Clearing flags on attachment: 181329 Committed r138820: <http://trac.webkit.org/changeset/138820>
WebKit Review Bot
Comment 13 2013-01-04 11:34:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.