Bug 106781

Summary: MediaStream API: Update MediaStreamTrack::readyState to match specification
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, haraken, hta, leviw, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2013-01-14 05:03:59 PST
readyState is now a string and no longer an integer.
Attachments
Patch (7.91 KB, patch)
2013-01-14 06:13 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (7.76 KB, patch)
2013-01-15 06:40 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2013-01-14 06:13:09 PST
Created attachment 182563 [details] Patch
Tommy Widenflycht
Comment 2 2013-01-14 06:14:34 PST
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
Adam Barth
Comment 3 2013-01-14 09:24:04 PST
Comment on attachment 182563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182563&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:125 > + You've got an extra blank line here.
WebKit Review Bot
Comment 4 2013-01-14 09:30:21 PST
Comment on attachment 182563 [details] Patch Clearing flags on attachment: 182563 Committed r139618: <http://trac.webkit.org/changeset/139618>
WebKit Review Bot
Comment 5 2013-01-14 09:30:25 PST
All reviewed patches have been landed. Closing bug.
Levi Weintraub
Comment 6 2013-01-14 17:38:37 PST
Speculatively rolled out in r139696. It appeared to be causing crashes in Debug bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fregions%2Fautoheight-allregions-nobreaks.html If the crashes continue, I'll roll this back in tomorrow.
Tommy Widenflycht
Comment 7 2013-01-15 02:08:07 PST
Wrong patch but right patch author... The culprit is https://bugs.webkit.org/show_bug.cgi?id=106660. Found and fixed the real problem.
Tommy Widenflycht
Comment 8 2013-01-15 02:26:58 PST
https://bugs.webkit.org/show_bug.cgi?id=106886
Tommy Widenflycht
Comment 9 2013-01-15 06:40:45 PST
Created attachment 182756 [details] Patch
Tommy Widenflycht
Comment 10 2013-01-15 06:41:49 PST
Taking the opportunity to address Adams comment about an extra line.
Levi Weintraub
Comment 11 2013-01-15 11:08:46 PST
Thanks for getting to the bottom of this!
Kentaro Hara
Comment 12 2013-01-16 01:31:22 PST
Comment on attachment 182756 [details] Patch Looks OK
WebKit Review Bot
Comment 13 2013-01-16 01:35:54 PST
Comment on attachment 182756 [details] Patch Clearing flags on attachment: 182756 Committed r139849: <http://trac.webkit.org/changeset/139849>
WebKit Review Bot
Comment 14 2013-01-16 01:35:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.