Bug 106864

Summary:

[EFL][WK2] Process single tap using mouse move, down and up event.

Product:

WebKit

Reporter:

Eunmi Lee <enmi.lee>

Component:

WebKit EFL

Assignee:

Eunmi Lee <enmi.lee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, d-r, gyuyoung.kim, lucas.de.marchi, luiz, noam, rakuco, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

102643

Bug Blocks:

111702

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Eunmi Lee

Reported 2013-01-14 20:37:37 PST

Process single tap gesture of WebKit2 EFL port using WebEvent::GestureSingleTap, and enable GESTURE_EVENTS to use GestureSingleTap in the WebKit2 EFL if WEBKIT2 and TILED_BACKING_STORE are enabled.

Attachments
Patch (5.49 KB, patch) 2013-01-14 20:54 PST, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (5.49 KB, patch) 2013-01-15 02:19 PST, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (5.38 KB, patch) 2013-03-04 23:31 PST, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (17.03 KB, patch) 2013-03-05 21:28 PST, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (21.53 KB, patch) 2013-03-18 00:18 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (21.77 KB, patch) 2013-03-19 03:29 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (21.87 KB, patch) 2013-07-04 00:00 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (21.50 KB, patch) 2013-07-29 00:34 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (21.68 KB, patch) 2013-08-07 04:21 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Patch (8.03 KB, patch) 2013-10-18 02:24 PDT, Eunmi Lee	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Eunmi Lee

Comment 1 2013-01-14 20:54:16 PST

Created attachment 182692 [details] Patch

Eunmi Lee

Comment 2 2013-01-15 02:19:21 PST

Created attachment 182724 [details] Patch Update patch for changed Bug 102643

Eunmi Lee

Comment 3 2013-03-04 23:31:47 PST

Created attachment 191411 [details] Patch Rebased.

Eunmi Lee

Comment 4 2013-03-05 21:28:37 PST

Created attachment 191646 [details] Patch Rebase and add WKViewSendGestureEvent().

Eunmi Lee

Comment 5 2013-03-18 00:18:56 PDT

Created attachment 193495 [details] Patch Modified codes to use EFLGestureEvent.

Eunmi Lee

Comment 6 2013-03-19 03:29:08 PDT

Created attachment 193775 [details] Patch Rebase and rename EFLGestureEvent to EwkGestureEvent.

Eunmi Lee

Comment 7 2013-07-04 00:00:04 PDT

Created attachment 206055 [details] Patch Rebased.

Chris Dumez

Comment 8 2013-07-04 00:30:16 PDT

(In reply to comment #7) > Created an attachment (id=206055) [details] > Patch > > Rebased. The patch does not apply.

Eunmi Lee

Comment 9 2013-07-29 00:34:57 PDT

Created attachment 207625 [details] Patch Rebase.

Eunmi Lee

Comment 10 2013-08-07 04:21:46 PDT

Created attachment 208250 [details] Patch Rebase.

Eunmi Lee

Comment 11 2013-10-16 23:09:34 PDT

I will update patch because GESTURE_EVENTS will be removed.

Eunmi Lee

Comment 12 2013-10-18 02:24:37 PDT

Created attachment 214552 [details] Patch Process single tap using mouse events instead of GestureSingleTap event.

Chris Dumez

Comment 13 2013-10-18 06:59:00 PDT

Comment on attachment 214552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review LGTM % the mouse move which seems a little bit odd. r=me. > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142 > + WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove); So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough?

Eunmi Lee

Comment 14 2013-11-17 23:54:24 PST

(In reply to comment #13) > (From update of attachment 214552 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review > > LGTM % the mouse move which seems a little bit odd. r=me. > > > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142 > > + WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove); > > So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough? Thanks for review! (I'm late) MouseMoveEvent is needed to move the mouse pointer to the clicked location.

WebKit Commit Bot

Comment 15 2013-11-18 00:22:50 PST

Comment on attachment 214552 [details] Patch Clearing flags on attachment: 214552 Committed r159401: <http://trac.webkit.org/changeset/159401>

WebKit Commit Bot

Comment 16 2013-11-18 00:22:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.