Bug 107132

Summary: [Chromium] Give webkit_support a chance to reset state between layout test runs
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: Tools / TestsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, fishd, jsbell, peter+ews, pilgrim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 107916    
Bug Blocks: 82948, 106457    
Attachments:
Description Flags
v1 patch
none
Patch none

Darin Fisher (:fishd, Google)
Reported 2013-01-17 08:29:39 PST
[Chromium] Give webkit_support a chance to reset state between layout test runs We currently only have need for this on OS(ANDROID), but now it would be useful to have a hook for resetting state on all platforms.
Attachments
v1 patch (1.50 KB, patch)
2013-01-17 08:34 PST, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2013-01-23 19:20 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2013-01-17 08:30:44 PST
Corresponding Chromium patch: https://codereview.chromium.org/11946027/
Darin Fisher (:fishd, Google)
Comment 2 2013-01-17 08:34:12 PST
Created attachment 183195 [details] v1 patch The Chromium side of this change needs to land first.
Darin Fisher (:fishd, Google)
Comment 3 2013-01-17 08:35:14 PST
(And, I need to also do a DEPS roll.)
WebKit Review Bot
Comment 4 2013-01-17 08:36:36 PST
Comment on attachment 183195 [details] v1 patch Attachment 183195 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15940134
Peter Beverloo (cr-android ews)
Comment 5 2013-01-17 08:41:40 PST
Comment on attachment 183195 [details] v1 patch Attachment 183195 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15941066
Mark Pilgrim (Google)
Comment 6 2013-01-23 19:20:48 PST
Created attachment 184382 [details] Patch
Mark Pilgrim (Google)
Comment 7 2013-01-23 19:21:30 PST
Comment on attachment 184382 [details] Patch Chromium patch has landed and DEPS have been rolled. Resubmitting identical patch against ToT.
WebKit Review Bot
Comment 8 2013-01-23 21:53:39 PST
Comment on attachment 184382 [details] Patch Clearing flags on attachment: 184382 Committed r140653: <http://trac.webkit.org/changeset/140653>
WebKit Review Bot
Comment 9 2013-01-23 21:53:42 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2013-01-24 22:28:08 PST
Re-opened since this is blocked by bug 107916
Mark Pilgrim (Google)
Comment 11 2013-02-14 08:41:55 PST
Made unnecessary by taking a different approach in http://src.chromium.org/viewvc/chrome?view=rev&revision=181641
Note You need to log in before you can comment on or make changes to this bug.