Bug 107201

Summary: BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2013-01-17 16:40:54 PST
BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
Attachments
Patch (2.92 KB, patch)
2013-01-17 16:44 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.01 KB, patch)
2013-01-17 17:06 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-01-17 16:44:32 PST
Created attachment 183315 [details] Patch
Tony Gentilcore
Comment 2 2013-01-17 16:58:41 PST
Comment on attachment 183315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50 > +static const size_t pendingTokenLimit = 4000; This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME).
Adam Barth
Comment 3 2013-01-17 17:04:41 PST
(In reply to comment #2) > (From update of attachment 183315 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review > > > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50 > > +static const size_t pendingTokenLimit = 4000; > > This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME). I just grabbed the constant from Eric's patch. I'd be happy to add a FIXME saying that it's arbitrary and needs to be tuned.
Adam Barth
Comment 4 2013-01-17 17:06:56 PST
Created attachment 183323 [details] Patch
WebKit Review Bot
Comment 5 2013-01-17 18:02:18 PST
Comment on attachment 183323 [details] Patch Clearing flags on attachment: 183323 Committed r140079: <http://trac.webkit.org/changeset/140079>
WebKit Review Bot
Comment 6 2013-01-17 18:02:23 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 7 2013-01-17 18:24:18 PST
Thanks!
Note You need to log in before you can comment on or make changes to this bug.