Bug 107752

Summary:

[CSS Regions] Selecting text inside an empty region causes selection outside the region area

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dglazkov, eric, esprehn+autocc, hyatt, mihnea, ojan.autocc, rniwa, WebkitBugTracker, webkit.review.bot

Priority:

Keywords:

AdobeTracked

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57312

Attachments:

Description	Flags
test case	none
Patch	buildbot: commit-queue-
Patch 2	none
Patch for landing	none

Zoltan Horvath

Reported 2013-01-23 15:47:46 PST

Created attachment 184333 [details] test case Selecting text inside an empty region causes selection outside the region area. Open the testfile and make a selection inside the blue rectangle, the selection will appear on the text of the #rectangle block.

Attachments
test case (1.76 KB, text/html) 2013-01-23 15:47 PST, Zoltan Horvath	no flags	Details
Patch (5.69 KB, patch) 2013-03-10 14:19 PDT, Mihnea Ovidenie	buildbot: commit-queue-	Details Formatted Diff Diff
Patch 2 (5.67 KB, patch) 2013-03-13 01:52 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (6.06 KB, patch) 2013-03-15 00:17 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2013-03-10 14:19:42 PDT

Created attachment 192386 [details] Patch

Build Bot

Comment 2 2013-03-10 14:52:14 PDT

Comment on attachment 192386 [details] Patch Attachment 192386 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17130326 New failing tests: fast/css/sticky/sticky-both-sides.html

WebKit Review Bot

Comment 3 2013-03-10 17:01:15 PDT

Comment on attachment 192386 [details] Patch Attachment 192386 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17114293 New failing tests: fast/repaint/japanese-rl-selection-repaint-in-regions.html

Mihnea Ovidenie

Comment 4 2013-03-13 01:52:08 PDT

Created attachment 192882 [details] Patch 2 Updated patch, the failure will be fixed part of: https://bugs.webkit.org/show_bug.cgi?id=106097

Dave Hyatt

Comment 5 2013-03-13 13:11:58 PDT

Comment on attachment 192882 [details] Patch 2 r=me

Dave Hyatt

Comment 6 2013-03-13 13:12:24 PDT

This is kind of weird. I'll r+ it, but it would probably be better to keep hit testing from going outside of the flow thread in the first place.

Mihnea Ovidenie

Comment 7 2013-03-15 00:17:57 PDT

Created attachment 193247 [details] Patch for landing

WebKit Review Bot

Comment 8 2013-03-15 01:10:25 PDT

Comment on attachment 193247 [details] Patch for landing Clearing flags on attachment: 193247 Committed r145884: <http://trac.webkit.org/changeset/145884>

WebKit Review Bot

Comment 9 2013-03-15 01:10:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.