Bug 108632

Summary: REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Gabor Rapcsanyi <rgabor>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, cmarcelo, gaborb, galpeter, hausmann, loki, ojan.autocc, ossy, psychon, rgabor, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 108645, 65766    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2013-02-01 06:54:17 PST
Tested on QtWebKit, but it might be valid on other platforms too. - r137993 (with r138032 buildfix applied): http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7810 - r137994 (with r138032 buildfix applied): http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7703
Attachments
Patch (1.92 KB, patch)
2013-02-25 08:10 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-02-01 09:10:40 PST
- ToT (r141579) - http://cute1.inf.u-szeged.hu:8010/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7809 - JSC tests still hang and inspector tests still crash - ToT (r141590) with reverted r137994 and r138474 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7811 - JSC tests pass, but inspector tests still crash (maybe related to other bug too)
Csaba Osztrogonác
Comment 2 2013-02-15 03:25:05 PST
The bug is still valid on ToT . :-/ Are you going to fix it or should we revert the buggy patch until somebody find the proper fix? r142785 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7876 r142785 (with reverted r137994 and r138474) - http://trac.webkit.org/changeset/142785
Csaba Osztrogonác
Comment 3 2013-02-15 03:25:44 PST
(In reply to comment #2) > The bug is still valid on ToT . :-/ Are you going to fix it or should > we revert the buggy patch until somebody find the proper fix? > > r142785 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7876 > r142785 (with reverted r137994 and r138474) - ooops, wrong URL, here is the correct one: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7877
Uli Schlachter
Comment 4 2013-02-15 07:42:04 PST
Assuming you mean me with "you": Nope, no idea what I could do about this. I don't see how the patch could cause hangs unless mprotect() is painfully slow on ARM and gets called too often. Also, I don't have any ARM devices to experiment with. So the best that I can suggest: Restrict the #if OS(LINUX) in OSAllocatorPosix.cpp to also exclude ARM so that on these devices overcommit is still used.
Simon Hausmann
Comment 5 2013-02-25 08:10:12 PST
Created attachment 190062 [details] Patch Patch re-enables overcommit on ARM
Csaba Osztrogonác
Comment 6 2013-02-25 22:38:30 PST
Just a note: It caused problem with only with ARM Thumb2 assembler, but didn't with ARM traditional assembler on the same hardware. So I think the problem is something else here. Maybe a hidden bug was revealed by changing allocator.
Csaba Osztrogonác
Comment 7 2013-02-27 04:01:49 PST
Comment on attachment 190062 [details] Patch rs=me as workaround until proper fix
Csaba Osztrogonác
Comment 8 2013-02-27 04:02:41 PST
I checked this patch on the bot and it fixed most of the failures on Thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7938 The remaining ~150 inspector crash is unrelated to this bug, needs more investigation.
WebKit Review Bot
Comment 9 2013-02-27 04:11:11 PST
Comment on attachment 190062 [details] Patch Clearing flags on attachment: 190062 Committed r144170: <http://trac.webkit.org/changeset/144170>
WebKit Review Bot
Comment 10 2013-02-27 04:11:16 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 11 2013-02-27 05:32:59 PST
Reopen, because only the workaround landed, we need to find the root of the problem. (rgabor said he will check it)
Gabor Rapcsanyi
Comment 12 2013-03-05 07:54:04 PST
I opened a new bug for this: https://bugs.webkit.org/show_bug.cgi?id=111441
Csaba Osztrogonác
Comment 13 2013-03-05 07:58:00 PST
*** This bug has been marked as a duplicate of bug 111441 ***
Note You need to log in before you can comment on or make changes to this bug.