Bug 109227

Summary: [EFL][Qt][WK2] Dark actual image in webgl-composite-modes-repaint test.
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: WebKit2Assignee: Viatcheslav Ostapenko <ostap73>
Status: RESOLVED WONTFIX    
Severity: Normal CC: gyuyoung.kim, jamesr, kalyan.kondapally, laszlo.gombos, mcatanzaro, noam, rakuco, sergio, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104459, 105029    
Attachments:
Description Flags
webgl-composite-modes-repaint-actual.png
none
webgl-composite-modes-repaint-expected.png
none
Patch laszlo.gombos: review-

Viatcheslav Ostapenko
Reported 2013-02-07 13:38:46 PST
Created attachment 187169 [details] webgl-composite-modes-repaint-actual.png Check attached expected and actual images.
Attachments
webgl-composite-modes-repaint-actual.png (4.53 KB, image/png)
2013-02-07 13:38 PST, Viatcheslav Ostapenko 		no flags
Details
webgl-composite-modes-repaint-expected.png (4.47 KB, image/png)
2013-02-07 13:40 PST, Viatcheslav Ostapenko 		no flags
Details
Patch (6.38 KB, patch)
2013-02-24 14:44 PST, Viatcheslav Ostapenko 		laszlo.gombos: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2013-02-07 13:40:52 PST
Created attachment 187170 [details] webgl-composite-modes-repaint-expected.png
Viatcheslav Ostapenko
Comment 2 2013-02-12 00:18:22 PST
It appears that in webgl-composite-modes-repaint test everything works as it implemented. This test uses fast/repaint/resources/repaint.js to invoke repaintTest after initial paint. repaint.js forces page re-layout and uses testRunner.display() before invoking testRunner.js . testRunner.display() paints page contents shadowed by gray surface, so this test produces darker blue tiles with canvas content composited on top. The repaintTest() method contains code which only changes canvas content, so only canvases get updated, but not tiles. From all this it looks that webgl-composite-modes-repaint-actual.png is correct test output. At the same time on chromium canvas update causes full page repaint and final page snapshot appears brighter.
Noam Rosenthal
Comment 3 2013-02-12 09:49:24 PST
chromium pixel test results don't show the repaint-counter "Grayness".
Viatcheslav Ostapenko
Comment 4 2013-02-12 09:53:43 PST
(In reply to comment #3) > chromium pixel test results don't show the repaint-counter "Grayness". Yes, that's what I'm trying to figure out now. It seems chromium does full screen update instead of canvas update. I need more digging.
James Robinson
Comment 5 2013-02-12 12:06:24 PST
(In reply to comment #4) > (In reply to comment #3) > > chromium pixel test results don't show the repaint-counter "Grayness". > > Yes, that's what I'm trying to figure out now. > It seems chromium does full screen update instead of canvas update. I need more digging. That's what happens in chromium in compositing mode.
Viatcheslav Ostapenko
Comment 6 2013-02-12 12:33:40 PST
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > chromium pixel test results don't show the repaint-counter "Grayness". > > > > Yes, that's what I'm trying to figure out now. > > It seems chromium does full screen update instead of canvas update. I need more digging. > > That's what happens in chromium in compositing mode. Is it by design or is it a known bug?
Noam Rosenthal
Comment 7 2013-02-12 12:48:37 PST
I think we should close this bug as INVALID, even though I agree that the difference between the "bright" Chromium version and the gray Mac/Qt/EFL version is confusing.
Viatcheslav Ostapenko
Comment 8 2013-02-12 13:03:48 PST
(In reply to comment #7) > I think we should close this bug as INVALID, even though I agree that the difference between the "bright" Chromium version and the gray Mac/Qt/EFL version is confusing. Should I add port specific snapshots for expected.png?
Kalyan
Comment 9 2013-02-23 06:21:50 PST
(In reply to comment #8) > (In reply to comment #7) > > Should I add port specific snapshots for expected.png? I would propose to add them. Even though expected.png has the "Grayness" it would be at least possible to track any regression with canvas content.
Viatcheslav Ostapenko
Comment 10 2013-02-24 14:44:05 PST
Created attachment 189989 [details] Patch
Laszlo Gombos
Comment 11 2013-02-27 13:49:52 PST
Comment on attachment 189989 [details] Patch The image for the expected test result does not seems to be correct. Can you double-check ?
Michael Catanzaro
Comment 12 2017-03-11 10:49:29 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.