Bug 111013

Summary: check-webkit-style should not check within SHADER(...) macros
Product: WebKit Reporter: Michelangelo De Simone <michelangelo>
Component: Tools / TestsAssignee: Michelangelo De Simone <michelangelo>
Status: RESOLVED INVALID    
Severity: Normal CC: krit, mvujovic
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Simple example none

Michelangelo De Simone
Reported 2013-02-27 14:45:40 PST
We often use SHADER(..) macros in CSS CustomFilters; this macro wraps GLSL code which does not necessarily follows the same convention we have in C++.
Attachments
Simple example (1.08 KB, patch)
2013-03-29 10:01 PDT, Michelangelo De Simone 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michelangelo De Simone
Comment 1 2013-03-29 10:01:05 PDT
Created attachment 195757 [details] Simple example
Michelangelo De Simone
Comment 2 2013-03-29 10:02:52 PDT
Comment on attachment 195757 [details] Simple example Adding a shader function such as "css_StyleTestDummyFunction" within a SHADER() macro triggers the style-checker with the following error: css_StyleTestDummyFunction is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Note You need to log in before you can comment on or make changes to this bug.