Bug 111428

Summary: [EFL][WebGL] Enable webgl-background-color test.
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit EFLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105093    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kalyan
Reported 2013-03-05 05:10:27 PST
Currently, the test misses Test expectation files.
Attachments
Patch (7.88 KB, patch)
2013-03-05 05:31 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
Patch (7.85 KB, patch)
2013-03-05 20:11 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2013-06-08 16:25 PDT, Kalyan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2013-03-05 05:31:04 PST
Created attachment 191474 [details] Patch
WebKit Review Bot
Comment 2 2013-03-05 05:33:16 PST
Attachment 191474 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.txt']" exit_code: 1 LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kalyan
Comment 3 2013-03-05 20:11:14 PST
Created attachment 191643 [details] Patch
WebKit Review Bot
Comment 4 2013-03-05 20:14:33 PST
Attachment 191643 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.txt']" exit_code: 1 LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2013-05-16 13:12:38 PDT
Comment on attachment 191643 [details] Patch Just so you know, such patch does not really need review but r=me anyway.
Kalyan
Comment 6 2013-06-08 16:25:44 PDT
Created attachment 204100 [details] Patch
WebKit Commit Bot
Comment 7 2013-06-08 16:58:18 PDT
Comment on attachment 204100 [details] Patch Clearing flags on attachment: 204100 Committed r151350: <http://trac.webkit.org/changeset/151350>
WebKit Commit Bot
Comment 8 2013-06-08 16:58:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.