Bug 112165

Summary: [V8] Get rid of GetFromContext world type
Product: WebKit Reporter: Marja Hölttä <marja>
Component: New BugsAssignee: Marja Hölttä <marja>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, alecflett, dcarney, dglazkov, dgrogan, eric.carlson, feature-media-reviews, haraken, japhet, jer.noble, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112250    
Bug Blocks: 110874    
Attachments:
Description Flags
Patch haraken: review+, webkit.review.bot: commit-queue-

Marja Hölttä
Reported 2013-03-12 10:34:04 PDT
It was introduced by bug 111724. We can get rid of it by passing the world type explicitly to the HasInstance functions.
Attachments
Patch (105.10 KB, patch)
2013-03-12 10:41 PDT, Marja Hölttä 		haraken: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Marja Hölttä
Comment 1 2013-03-12 10:41:23 PDT
Created attachment 192763 [details] Patch
WebKit Review Bot
Comment 2 2013-03-12 11:20:52 PDT
Comment on attachment 192763 [details] Patch Attachment 192763 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17138123
Kentaro Hara
Comment 3 2013-03-12 17:10:15 PDT
Comment on attachment 192763 [details] Patch Looks reasonable. Please fix the debug build failure before landing. (I was wondering why you had to introduce GetFromContext in the previous patch:-)
Marja Hölttä
Comment 4 2013-03-13 05:10:10 PDT
There are some newly discovered problems which prevent doing this, see bug 112250.
Marja Hölttä
Comment 5 2013-03-14 04:03:18 PDT
This is no longer needed, the new patch in bug 111724 no longer introduces this GetFromContext world type.
Note You need to log in before you can comment on or make changes to this bug.