Bug 112679

Summary: [Qt][WK2] Clean up sanity checks related to gesture recognition
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, jturcotte, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111751    
Bug Blocks:    
Attachments:
Description Flags
Patch jturcotte: review+

Andras Becsi
Reported 2013-03-19 03:49:19 PDT
[Qt][WK2] Clean up sanity checks related to gesture recognition
Attachments
Patch (6.16 KB, patch)
2013-03-19 03:52 PDT, Andras Becsi 		jturcotte: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2013-03-19 03:52:58 PDT
Created attachment 193779 [details] Patch
Benjamin Poulain
Comment 2 2013-03-19 15:12:33 PDT
Comment on attachment 193779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193779&action=review Signed off by me for WebKit2. > Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp:166 > + // Check for sane event delivery. At this point neither a pan gesture nor a pinch gesture should be active. > + ASSERT(!m_viewportItem->isDragging() && !(m_pinchStartScale > 0)); You can split this into 2 assertions.
Jocelyn Turcotte
Comment 3 2013-03-20 06:03:54 PDT
Comment on attachment 193779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193779&action=review >> Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp:166 >> + ASSERT(!m_viewportItem->isDragging() && !(m_pinchStartScale > 0)); > > You can split this into 2 assertions. r=me if you fix this.
Andras Becsi
Comment 4 2013-03-20 06:19:38 PDT
(In reply to comment #3) > (From update of attachment 193779 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=193779&action=review > > >> Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp:166 > >> + ASSERT(!m_viewportItem->isDragging() && !(m_pinchStartScale > 0)); > > > > You can split this into 2 assertions. > > r=me if you fix this. Will do.
Andras Becsi
Comment 5 2013-03-20 09:51:53 PDT
Committed r146356: <http://trac.webkit.org/changeset/146356>
Note You need to log in before you can comment on or make changes to this bug.