Bug 11269

Summary: Qt/Linux DumpRenderTree needs "skip tests" functionality
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: PlatformAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mjs
Priority: P2    
Version: 420+   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
Patch to workaround DRT hangs related to Frame logic
mjs: review+
Add skip tests functionality to Qt/Linux DRT mjs: review+

Nikolas Zimmermann
Reported 2006-10-12 16:36:13 PDT
We need a persistent way to skip certain LayoutTests which make DRT crash or hang. Offer a file containing "tests to be skipped". Attaching a patch for this, and another patch which worksaround a Frame logic bug, as Maciej is still rewriting this code area, the real fix has to be delayed, instead a workaround is offered. I can successfully run run-webkit-tests --no-http now without crashes ;-)
Attachments
Patch to workaround DRT hangs related to Frame logic (2.50 KB, patch)
2006-10-12 16:37 PDT, Nikolas Zimmermann 		mjs: review+
DetailsFormatted DiffDiff
Add skip tests functionality to Qt/Linux DRT (6.38 KB, patch)
2006-10-12 16:40 PDT, Nikolas Zimmermann 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-10-12 16:37:53 PDT
Created attachment 11057 [details] Patch to workaround DRT hangs related to Frame logic It would be nice if Maciej could have a look at this, as I already discussed parts of this with him :-)
Nikolas Zimmermann
Comment 2 2006-10-12 16:40:00 PDT
Created attachment 11058 [details] Add skip tests functionality to Qt/Linux DRT
Maciej Stachowiak
Comment 3 2006-10-12 16:49:35 PDT
Comment on attachment 11057 [details] Patch to workaround DRT hangs related to Frame logic Seems like an ok workaround. r=me
Maciej Stachowiak
Comment 4 2006-10-12 16:50:23 PDT
Comment on attachment 11058 [details] Add skip tests functionality to Qt/Linux DRT r=me
Mark Rowe (bdash)
Comment 5 2006-10-12 18:37:55 PDT
Landed in r17020 and r17021.
Note You need to log in before you can comment on or make changes to this bug.