Bug 114113

Summary: [GTK][AC] Support masksToBounds for clutter AC backend.
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, joone
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113912    
Bug Blocks: 105699    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

ChangSeok Oh
Reported 2013-04-07 03:46:51 PDT
Masking layer doesn't work well. A test case is here, "Slide in" in http://www.apple.com/html5/showcase/transitions/
Attachments
Patch (4.32 KB, patch)
2013-04-07 03:59 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2013-04-07 05:21 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2013-04-07 05:34 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2013-04-07 10:40 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.73 KB, patch)
2013-04-12 05:11 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-04-07 03:59:08 PDT
Created attachment 196776 [details] Patch
ChangSeok Oh
Comment 2 2013-04-07 05:21:15 PDT
Created attachment 196782 [details] Patch
ChangSeok Oh
Comment 3 2013-04-07 05:34:43 PDT
Created attachment 196783 [details] Patch
ChangSeok Oh
Comment 5 2013-04-07 10:40:30 PDT
Created attachment 196795 [details] Patch
Gustavo Noronha (kov)
Comment 6 2013-04-08 14:59:34 PDT
Comment on attachment 196795 [details] Patch In the current implementation we do clipping at paint time, apparently because we need to take the scroll offset into consideration for the clipping, does this change work when a layer has masksToBounds and is scrolled?
ChangSeok Oh
Comment 7 2013-04-09 00:20:16 PDT
(In reply to comment #6) > (From update of attachment 196795 [details]) > In the current implementation we do clipping at paint time, apparently because we need to take the scroll offset into consideration for the clipping, does this change work when a layer has masksToBounds and is scrolled? yes. it seems working without any artifacts as I know. Would you let me know any sample for the case concerned? :)
ChangSeok Oh
Comment 8 2013-04-12 05:11:48 PDT
Created attachment 197747 [details] Patch
ChangSeok Oh
Comment 9 2013-04-12 05:13:15 PDT
Comment on attachment 197747 [details] Patch Added graphicsLayerActorSetMasksToBounds in GraphicsLayerClutter::setupContentsLayer
Gustavo Noronha (kov)
Comment 10 2013-04-19 06:10:04 PDT
Comment on attachment 197747 [details] Patch None that I know, remember to merge this one on webkit-clutter too.
WebKit Commit Bot
Comment 11 2013-04-19 06:49:59 PDT
Comment on attachment 197747 [details] Patch Clearing flags on attachment: 197747 Committed r148742: <http://trac.webkit.org/changeset/148742>
WebKit Commit Bot
Comment 12 2013-04-19 06:50:01 PDT
All reviewed patches have been landed. Closing bug.
ChangSeok Oh
Comment 13 2013-04-19 12:48:13 PDT
(In reply to comment #10) > (From update of attachment 197747 [details]) > None that I know, remember to merge this one on webkit-clutter too. Sure. I will~
Gustavo Noronha (kov)
Comment 14 2013-04-29 16:06:49 PDT
In webkit-clutter we do the clipping at paint time, I am not 100% on why, but I remember Joone explaining at some point. Merging this patch in webkit-clutter (which moved the clipping from paint time to setMasksToBounds time) broke the drawing of layers in pages such as this one: http://www.anthonycalzadilla.com/css3-ATAT/ I am still building webkit-gtk with clutter AC to test if that also happened in webkitgtk's case.
Gustavo Noronha (kov)
Comment 15 2013-04-29 16:14:07 PDT
Actually, this page is a better test, zooming and scrolling around should show the issue: https://developers.google.com/maps/documentation/javascript/examples/map-simple?hl=pt-br
Note You need to log in before you can comment on or make changes to this bug.