Bug 114455

Summary: [CSS Shaders] Parse the parameters descriptor
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, macpherson, menard, rniwa, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113695    
Attachments:
Description Flags
Patch for parameters.
none
Patch for parameters.
dino: review+
Patch for landing. none

Dirk Schulze
Reported 2013-04-11 11:59:36 PDT
Parse the parameters descriptor of the filter at-rule.
Attachments
Patch for parameters. (35.97 KB, patch)
2013-04-11 12:24 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch for parameters. (35.97 KB, patch)
2013-04-11 12:28 PDT, Dirk Schulze 		dino: review+
DetailsFormatted DiffDiff
Patch for landing. (35.96 KB, patch)
2013-04-11 12:40 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michelangelo De Simone
Comment 1 2013-04-11 12:01:38 PDT
*** This bug has been marked as a duplicate of bug 113565 ***
Dirk Schulze
Comment 2 2013-04-11 12:24:44 PDT
Created attachment 197651 [details] Patch for parameters.
Dirk Schulze
Comment 3 2013-04-11 12:26:41 PDT
The other bug is a dup.
Dirk Schulze
Comment 4 2013-04-11 12:28:22 PDT
Created attachment 197652 [details] Patch for parameters.
Dirk Schulze
Comment 5 2013-04-11 12:29:06 PDT
*** Bug 113565 has been marked as a duplicate of this bug. ***
Michelangelo De Simone
Comment 6 2013-04-11 12:32:03 PDT
(In reply to comment #3) > The other bug is a dup. I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion.
Dirk Schulze
Comment 7 2013-04-11 12:34:34 PDT
(In reply to comment #6) > (In reply to comment #3) > > > The other bug is a dup. > > I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion. And I am sure you know that I don't care.
Dean Jackson
Comment 8 2013-04-11 12:34:40 PDT
Comment on attachment 197652 [details] Patch for parameters. View in context: https://bugs.webkit.org/attachment.cgi?id=197652&action=review > Source/WebCore/ChangeLog:9 > + parametrization of CSS Shaders. typo: parameterization (although I'm not sure it is a real word anyway :)
Dirk Schulze
Comment 9 2013-04-11 12:40:40 PDT
Created attachment 197655 [details] Patch for landing.
WebKit Commit Bot
Comment 10 2013-04-11 13:03:49 PDT
Comment on attachment 197655 [details] Patch for landing. Clearing flags on attachment: 197655 Committed r148227: <http://trac.webkit.org/changeset/148227>
WebKit Commit Bot
Comment 11 2013-04-11 13:03:52 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 12 2013-04-11 17:44:26 PDT
It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ? http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm
Ryosuke Niwa
Comment 13 2013-04-11 17:48:22 PDT
(In reply to comment #12) > It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ? > > http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm (In reply to comment #12) > It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ? > > http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm I guess not. It's probably caused by the slave reboot. Sorry for the noise.
Note You need to log in before you can comment on or make changes to this bug.