Bug 115785

Summary:

[Qt][EFL][GTK] Failing CSS region tests

Product:

WebKit

Reporter:

Mátyás Mustoha <mmatyas>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kadam, kling, ossy, stavila, WebkitBugTracker, zan, zarvai

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

87008

Attachments:

Description	Flags
Patch	none

Mátyás Mustoha

Reported 2013-05-08 02:40:12 PDT

These tests fail after r149668. Could you check it? [Qt][GTK] fast/regions/webkit-flow-double-pagination-float-push.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r149668%20(50756)/fast/regions/webkit-flow-double-pagination-float-push-diffs.html fast/regions/webkit-flow-float-pushed-to-last-region.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r149668%20(50756)/fast/regions/webkit-flow-float-pushed-to-last-region-diffs.html fast/regions/webkit-flow-float-unable-to-push.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r149668%20(50756)/fast/regions/webkit-flow-float-unable-to-push-diffs.html fast/regions/webkit-flow-floats-inside-regions-bounds.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r149668%20(50756)/fast/regions/webkit-flow-floats-inside-regions-bounds-diffs.html [EFL] fast/regions/webkit-flow-float-pushed-to-last-region.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r149718%20(12027)/fast/regions/webkit-flow-float-pushed-to-last-region-diffs.html fast/regions/webkit-flow-float-unable-to-push.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r149718%20%2812027%29/fast/regions/webkit-flow-float-unable-to-push-diffs.html

Attachments
Patch (14.29 KB, patch) 2013-05-09 01:10 PDT, Radu Stavila	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zoltan Arvai

Comment 1 2013-05-08 05:57:29 PDT

Failing tests skipped on Qt in http://trac.webkit.org/changeset/149732. Please unskip it with the proper fix.

Radu Stavila

Comment 2 2013-05-09 01:10:35 PDT

Created attachment 201170 [details] Patch Changed tests to be platform independent by using Ahem and no font smoothing.

Antti Koivisto

Comment 3 2013-05-09 06:21:21 PDT

Comment on attachment 201170 [details] Patch r=me

WebKit Commit Bot

Comment 4 2013-05-09 06:47:46 PDT

Comment on attachment 201170 [details] Patch Clearing flags on attachment: 201170 Committed r149802: <http://trac.webkit.org/changeset/149802>

WebKit Commit Bot

Comment 5 2013-05-09 06:47:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.