Bug 115864

Summary: [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: WebKit QtAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED INVALID    
Severity: Normal CC: abecsi, allan.jensen, hausmann, kling, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57311    
Attachments:
Description Flags
proposed patch none

Zoltan Horvath
Reported 2013-05-09 09:56:03 PDT
Qt-port runs all the CSS-Exclusion tests. If there is an test failiure when running the tests there is no way to test via QtTestBrowser. This patch enables the feature in QtTestBrowser.
Attachments
proposed patch (2.60 KB, patch)
2013-05-09 09:59 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-05-09 09:59:54 PDT
Created attachment 201246 [details] proposed patch
Andreas Kling
Comment 2 2013-05-09 10:39:28 PDT
Comment on attachment 201246 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > Source/WebKit/qt/Api/qwebsettings.h:82 > + CSSExclusionsEnabled, I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility.
Zoltan Horvath
Comment 3 2013-05-09 11:14:24 PDT
(In reply to comment #2) > (From update of attachment 201246 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > > > Source/WebKit/qt/Api/qwebsettings.h:82 > > + CSSExclusionsEnabled, > > I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility. I don't want to break any compatibility. Do you know any way how to add this settings as a private setting?
Zoltan Horvath
Comment 4 2013-05-10 15:22:54 PDT
Comment on attachment 201246 [details] proposed patch We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug.
Simon Hausmann
Comment 5 2013-05-13 01:41:13 PDT
(In reply to comment #4) > (From update of attachment 201246 [details]) > We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug. I very much like that approach :)
Note You need to log in before you can comment on or make changes to this bug.