Bug 116060

Summary: fourthTier: DFG should separate link phase into things that must be done concurrently and things that must be done synchronously, and have a way of passing data from one to the other
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112839    
Attachments:
Description Flags
work in progress
none
work in progress
none
the patch
none
the patch barraclough: review+

Filip Pizlo
Reported 2013-05-13 14:15:43 PDT
Patch forthcoming.
Attachments
work in progress (42.79 KB, patch)
2013-05-13 14:18 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (98.32 KB, patch)
2013-05-14 15:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (100.08 KB, patch)
2013-05-14 16:49 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (100.48 KB, patch)
2013-05-15 10:22 PDT, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-05-13 14:18:03 PDT
Created attachment 201633 [details] work in progress
Filip Pizlo
Comment 2 2013-05-14 15:29:38 PDT
Created attachment 201765 [details] work in progress It seems like it's starting to work.
Filip Pizlo
Comment 3 2013-05-14 16:49:44 PDT
Created attachment 201771 [details] the patch
Filip Pizlo
Comment 4 2013-05-15 10:22:40 PDT
Created attachment 201853 [details] the patch Disassembly-related fixes.
Gavin Barraclough
Comment 5 2013-05-15 11:11:11 PDT
Comment on attachment 201853 [details] the patch I buy that Plan can be a struct for now. I expect that over time we'll want this to be a class, but we'll see. :-) Might be worth considering making some of the immutable data members const.
Filip Pizlo
Comment 6 2013-05-15 12:33:20 PDT
(In reply to comment #5) > (From update of attachment 201853 [details]) > I buy that Plan can be a struct for now. I expect that over time we'll want this to be a class, but we'll see. :-) > Might be worth considering making some of the immutable data members const. Yup, I've made some of the things const!
Filip Pizlo
Comment 7 2013-05-15 12:38:37 PDT
Landed in http://trac.webkit.org/changeset/150139
Note You need to log in before you can comment on or make changes to this bug.