Bug 116252

Summary: [CSS Regions][CSS Exclusions] shape-inside on regions should respect positioned shapes and overflow
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256, 115001    
Attachments:
Description Flags
proposed patch
none
proposed patch none

Zoltan Horvath
Reported 2013-05-16 16:33:35 PDT
Shape-inside on regions should respect positioned shapes and overflow.
Attachments
proposed patch (12.17 KB, patch)
2013-05-16 16:53 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (12.15 KB, patch)
2013-05-16 16:58 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-05-16 16:53:02 PDT
Created attachment 202003 [details] proposed patch
Zoltan Horvath
Comment 2 2013-05-16 16:58:07 PDT
Created attachment 202004 [details] proposed patch I can compare int with LayoutUnit, so I changed 1 line.
Dave Hyatt
Comment 3 2013-05-20 11:39:16 PDT
Comment on attachment 202004 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=202004&action=review r=me > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1729 > + LayoutUnit height = exclusionShapeInsideInfo->shapeLogicalTop() - absoluteLogicalTop; Minor nitpick. Call this logicalHeight and not just height.
Zoltan Horvath
Comment 4 2013-05-20 12:00:38 PDT
Comment on attachment 202004 [details] proposed patch Thanks for the review. Updated and landed in http://trac.webkit.org/changeset/150375
Note You need to log in before you can comment on or make changes to this bug.