Bug 117256

Created attachment 203850 [details] proposed implementation

Attachment 203850 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/curl/ResourceHandleManager.cpp']" exit_code: 1 Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:546: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:548: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:589: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 203852 [details] stylefixed implementation

Comment on attachment 203852 [details] stylefixed implementation View in context: https://bugs.webkit.org/attachment.cgi?id=203852&action=review Looks very good. I had a couple of things I'd like you to cleanup before we land. Thanks! > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:484 > + */ We don't usually add header comments like these. We prefer to have the function/method name describe what the method does. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:556 > + */ Comment is unecessary > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:574 > + */ Comment is unecessary > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:586 > + Vector<FormDataElement> elements = job->firstRequest().httpBody()->elements(); I don't think this Vector is needed.

(In reply to comment #4) > (From update of attachment 203852 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203852&action=review > > Looks very good. I had a couple of things I'd like you to cleanup before we land. Thanks! > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:484 > > + */ > > We don't usually add header comments like these. We prefer to have the function/method name describe what the method does. > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:556 > > + */ > > Comment is unecessary > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:574 > > + */ > > Comment is unecessary Okay, will remove these. > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:586 > > + Vector<FormDataElement> elements = job->firstRequest().httpBody()->elements(); > > I don't think this Vector is needed. Yeah that's true, I've missed it sorry. I'll update the patch in a few minutes.

Created attachment 203885 [details] patch with fixes This patch should include the requested changes.

Comment on attachment 203885 [details] patch with fixes Looks great! r=me.

Comment on attachment 203885 [details] patch with fixes Clearing flags on attachment: 203885 Committed r151255: <http://trac.webkit.org/changeset/151255>

All reviewed patches have been landed. Closing bug.

Do we have a master bug for the ongoing work of getting the curl backend alive? It would be useful.

(In reply to comment #10) > Do we have a master bug for the ongoing work of getting the curl backend alive? It would be useful. I didn't created a bug for it and I don't remember seeing it. So I'll create one and will it for the upcoming curl fixes.

(In reply to comment #11) > (In reply to comment #10) > > Do we have a master bug for the ongoing work of getting the curl backend alive? It would be useful. > > I didn't created a bug for it and I don't remember seeing it. So I'll create one and will it for the upcoming curl fixes. "will it" -> "will use it"