Bug 118061

Summary: [curl] Add "set-cookie" to appendable headers
Product: WebKit Reporter: Szabolcs David <davidsz>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, galpeter, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
Patch
none
Fixed changelog problem none

Szabolcs David
Reported 2013-06-26 08:19:02 PDT
The curl implementation does not allows the concatenating of "Set-Cookie" headers. (RFC 2109)
Attachments
Patch (1.14 KB, patch)
2013-06-26 08:22 PDT, Szabolcs David 		no flags
DetailsFormatted DiffDiff
Fixed changelog problem (1.16 KB, patch)
2013-06-27 02:11 PDT, Szabolcs David 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Szabolcs David
Comment 1 2013-06-26 08:22:17 PDT
Created attachment 205496 [details] Patch
Peter Gal
Comment 2 2013-06-26 08:57:02 PDT
(In reply to comment #1) > Created an attachment (id=205496) [details] > Patch Ah... yeah I missed that one in my patch.
Chris Dumez
Comment 3 2013-06-26 10:44:46 PDT
Comment on attachment 205496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please update this line and add a Changelog.
Peter Gal
Comment 4 2013-06-27 01:54:12 PDT
(In reply to comment #3) > (From update of attachment 205496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > Please update this line and add a Changelog. The title of the bug already describes the change I don't know what more can be described here.
Gyuyoung Kim
Comment 5 2013-06-27 02:07:33 PDT
Comment on attachment 205496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review >>> Source/WebCore/ChangeLog:8 >>> + No new tests (OOPS!). >> >> Please update this line and add a Changelog. > > The title of the bug already describes the change I don't know what more can be described here. Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html
Szabolcs David
Comment 6 2013-06-27 02:11:39 PDT
Created attachment 205578 [details] Fixed changelog problem
Peter Gal
Comment 7 2013-06-27 02:22:25 PDT
(In reply to comment #5) > (From update of attachment 205496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > > >>> Source/WebCore/ChangeLog:8 > >>> + No new tests (OOPS!). > >> > >> Please update this line and add a Changelog. > > > > The title of the bug already describes the change I don't know what more can be described here. > > Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html I know that, but still... oh well...
Chris Dumez
Comment 8 2013-06-27 02:43:52 PDT
Comment on attachment 205578 [details] Fixed changelog problem Thank you for updating the Changelog. r=me.
WebKit Commit Bot
Comment 9 2013-06-27 03:05:50 PDT
Comment on attachment 205578 [details] Fixed changelog problem Clearing flags on attachment: 205578 Committed r152085: <http://trac.webkit.org/changeset/152085>
WebKit Commit Bot
Comment 10 2013-06-27 03:05:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.