Bug 118081

Summary: [CSS Shapes] New positioning model: support for rounded rectangle shape-outside
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior
Bug Depends on: 118822    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
none
Patch none

Bem Jones-Bey
Reported 2013-06-26 14:32:38 PDT
Rounded rectangle support in the new positioning model.
Attachments
Patch (45.30 KB, patch)
2013-07-18 13:43 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (701.66 KB, application/zip)
2013-07-23 12:42 PDT, WebKit Commit Bot 		no flags
Details
Patch (52.15 KB, patch)
2013-07-23 14:00 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-07-18 11:32:24 PDT
This needs the borders patch to land first.
Bem Jones-Bey
Comment 2 2013-07-18 13:43:38 PDT
Created attachment 207018 [details] Patch Add rounded rectangle tests for shape-outside
Dean Jackson
Comment 3 2013-07-23 11:58:58 PDT
Comment on attachment 207018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review > LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15 > + // within the upper rounded corner part of the rectangle I assume we don't pick nits for things that are imported from external repositories.
WebKit Commit Bot
Comment 4 2013-07-23 12:42:33 PDT
Comment on attachment 207018 [details] Patch Rejecting attachment 207018 [details] from commit-queue. New failing tests: fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html Full output: http://webkit-queues.appspot.com/results/1137718
WebKit Commit Bot
Comment 5 2013-07-23 12:42:34 PDT
Created attachment 207342 [details] Archive of layout-test-results from webkit-cq-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Bem Jones-Bey
Comment 6 2013-07-23 13:48:29 PDT
Comment on attachment 207018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review >> LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15 >> + // within the upper rounded corner part of the rectangle > > I assume we don't pick nits for things that are imported from external repositories. Actually, that's a good catch, I'll update it and post a patch for the fix. I would be more than happy to get told about nits and other issues with the imported tests in the future, so that I can update them upstream as well.
Bem Jones-Bey
Comment 7 2013-07-23 13:49:32 PDT
(In reply to comment #6) > (From update of attachment 207018 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review > > >> LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15 > >> + // within the upper rounded corner part of the rectangle > > > > I assume we don't pick nits for things that are imported from external repositories. > > Actually, that's a good catch, I'll update it and post a patch for the fix. I would be more than happy to get told about nits and other issues with the imported tests in the future, so that I can update them upstream as well. Looks like I'm going to have to update this patch, since apparently one test escaped deletion. I'll make this change with the updated patch.
Bem Jones-Bey
Comment 8 2013-07-23 14:00:17 PDT
Created attachment 207347 [details] Patch Delete missed test and update nit
WebKit Commit Bot
Comment 9 2013-07-23 15:19:41 PDT
Comment on attachment 207347 [details] Patch Clearing flags on attachment: 207347 Committed r153063: <http://trac.webkit.org/changeset/153063>
WebKit Commit Bot
Comment 10 2013-07-23 15:19:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.