Bug 118090

Summary: [CSS Shapes] New positioning model: Negative margins
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior
Bug Depends on:    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Patch none

Bem Jones-Bey
Reported 2013-06-26 14:52:47 PDT
Test support for negative margins on the float and fix any issues. Tests: [ ]negative top margin [ ]negative left margin [ ]negative right margin [ ]negative bottom margin [ ]negative left margin right-left writing mode [ ]negative right margin right-left writing mode [ ]negative top margin vertical right-left writing mode [ ]negative left margin vertical right-left writing mode [ ]negative right margin vertical right-left writing mode [ ]negative bottom margin vertical right-left writing mode [ ]negative top margin vertical left-right writing mode [ ]negative left margin vertical left-right writing mode [ ]negative right margin vertical left-right writing mode [ ]negative bottom margin vertical left-right writing mode
Attachments
Patch (48.31 KB, patch)
2013-10-10 14:59 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (512.79 KB, application/zip)
2013-10-10 15:47 PDT, Build Bot 		no flags
Details
Patch (48.27 KB, patch)
2013-10-10 15:57 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-10-10 14:59:58 PDT
Created attachment 213931 [details] Patch
Build Bot
Comment 2 2013-10-10 15:47:24 PDT
Comment on attachment 213931 [details] Patch Attachment 213931 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3900017 New failing tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html
Build Bot
Comment 3 2013-10-10 15:47:26 PDT
Created attachment 213938 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Bem Jones-Bey
Comment 4 2013-10-10 15:57:15 PDT
Created attachment 213941 [details] Patch This time with everything working
WebKit Commit Bot
Comment 5 2013-10-11 09:51:37 PDT
Comment on attachment 213941 [details] Patch Clearing flags on attachment: 213941 Committed r157305: <http://trac.webkit.org/changeset/157305>
WebKit Commit Bot
Comment 6 2013-10-11 09:51:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.