Bug 118454

Summary:

[EFL] Enable CSS Image Orientation

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bfulgham, buildbot, cdumez, commit-queue, dbates, d-r, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, japhet, lucas.de.marchi, mcatanzaro, philn, rakuco, rniwa, sergio, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP-1	none
WIP-2	none
WIP-3	none
WIP-4	none
WIP-5 pass efl and gtk ports	none
WIP-6 (EFL, GTK and Mac ports)	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
WIP-7	none
WIP-8	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none

Gyuyoung Kim

Reported 2013-07-07 16:59:53 PDT

SSIA. But, this bug will be used to keep WIP patches mainly.

Attachments
WIP-1 (29.78 KB, patch) 2013-07-07 17:03 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-2 (47.81 KB, patch) 2013-07-08 07:36 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-3 (53.19 KB, patch) 2013-07-10 02:58 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-4 (52.62 KB, patch) 2013-07-12 01:53 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-5 pass efl and gtk ports (57.48 KB, patch) 2013-07-12 22:52 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-6 (EFL, GTK and Mac ports) (66.38 KB, patch) 2013-07-15 19:25 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (555.10 KB, application/zip) 2013-07-18 12:28 PDT, Build Bot	no flags	Details
WIP-7 (57.94 KB, patch) 2013-07-19 03:09 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-8 (68.51 KB, patch) 2013-07-19 21:46 PDT, Gyuyoung Kim	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (545.98 KB, application/zip) 2013-07-22 03:58 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (312.49 KB, application/zip) 2013-07-31 16:40 PDT, Build Bot	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-07-07 17:03:37 PDT

Created attachment 206211 [details] WIP-1

WebKit Commit Bot

Comment 2 2013-07-07 17:05:42 PDT

Attachment 206211 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/ImageSource.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1 Source/WebCore/platform/DragImage.h:78: The parameter name "orientation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/loader/cache/CachedImage.cpp:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/loader/cache/CachedImage.cpp:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/loader/cache/CachedImage.cpp:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/loader/cache/CachedImage.cpp:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2013-07-07 17:10:50 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1048215

Early Warning System Bot

Comment 4 2013-07-07 17:10:51 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/976920

EFL EWS Bot

Comment 5 2013-07-07 17:19:31 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/977702

kov's GTK+ EWS bot

Comment 6 2013-07-07 17:20:31 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/975163

EFL EWS Bot

Comment 7 2013-07-07 17:22:03 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1002250

Build Bot

Comment 8 2013-07-07 17:29:34 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1031223

Build Bot

Comment 9 2013-07-07 17:43:02 PDT

Comment on attachment 206211 [details] WIP-1 Attachment 206211 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/988169

Gyuyoung Kim

Comment 10 2013-07-08 07:36:57 PDT

Created attachment 206243 [details] WIP-2

Gyuyoung Kim

Comment 11 2013-07-10 02:58:29 PDT

Created attachment 206376 [details] WIP-3

Gyuyoung Kim

Comment 12 2013-07-12 01:53:17 PDT

Created attachment 206515 [details] WIP-4

Gyuyoung Kim

Comment 13 2013-07-12 22:52:03 PDT

Created attachment 206593 [details] WIP-5 pass efl and gtk ports

Gyuyoung Kim

Comment 14 2013-07-15 19:25:49 PDT

Created attachment 206718 [details] WIP-6 (EFL, GTK and Mac ports)

Early Warning System Bot

Comment 15 2013-07-15 19:33:30 PDT

Comment on attachment 206718 [details] WIP-6 (EFL, GTK and Mac ports) Attachment 206718 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1080055

Early Warning System Bot

Comment 16 2013-07-15 19:35:17 PDT

Comment on attachment 206718 [details] WIP-6 (EFL, GTK and Mac ports) Attachment 206718 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1095002

Build Bot

Comment 17 2013-07-17 18:25:18 PDT

Comment on attachment 206718 [details] WIP-6 (EFL, GTK and Mac ports) Attachment 206718 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1103365

Build Bot

Comment 18 2013-07-18 12:28:28 PDT

Comment on attachment 206718 [details] WIP-6 (EFL, GTK and Mac ports) Attachment 206718 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1098655 New failing tests: fast/canvas/pattern-with-transform.html fast/canvas/canvas-pattern-modify.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html webgl/conformance/extensions/oes-texture-float-with-canvas.html canvas/philip/tests/2d.pattern.modify.canvas2.html fast/canvas/webgl/tex-image-webgl.html canvas/philip/tests/2d.pattern.paint.orientation.canvas.html fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.modify.canvas1.html http/tests/inspector/inspect-element.html fast/canvas/webgl/texture-npot.html canvas/philip/tests/initial.reset.pattern.html webgl/conformance/textures/gl-teximage.html webgl/conformance/context/premultiplyalpha-test.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html editing/pasteboard/copy-image-with-alt-text.html canvas/philip/tests/2d.pattern.basic.canvas.html webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html fast/canvas/webgl/tex-sub-image-2d-bad-args.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html fast/canvas/webgl/texture-active-bind.html fast/canvas/webgl/canvas-2d-webgl-texture.html

Build Bot

Comment 19 2013-07-18 12:28:32 PDT

Created attachment 207014 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Gyuyoung Kim

Comment 20 2013-07-19 03:09:57 PDT

Created attachment 207075 [details] WIP-7

Early Warning System Bot

Comment 21 2013-07-19 03:18:36 PDT

Comment on attachment 207075 [details] WIP-7 Attachment 207075 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1104798

Early Warning System Bot

Comment 22 2013-07-19 03:19:24 PDT

Comment on attachment 207075 [details] WIP-7 Attachment 207075 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1106825

Build Bot

Comment 23 2013-07-19 03:33:37 PDT

Comment on attachment 207075 [details] WIP-7 Attachment 207075 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1104799

Build Bot

Comment 24 2013-07-19 03:45:45 PDT

Comment on attachment 207075 [details] WIP-7 Attachment 207075 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1100735

Build Bot

Comment 25 2013-07-19 03:55:21 PDT

Comment on attachment 207075 [details] WIP-7 Attachment 207075 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1110823

Gyuyoung Kim

Comment 26 2013-07-19 21:46:13 PDT

Created attachment 207181 [details] WIP-8

Build Bot

Comment 27 2013-07-22 03:58:02 PDT

Comment on attachment 207181 [details] WIP-8 Attachment 207181 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1080442 New failing tests: fast/canvas/pattern-with-transform.html webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html webgl/conformance/extensions/oes-texture-float-with-canvas.html canvas/philip/tests/2d.pattern.modify.canvas2.html fast/canvas/webgl/tex-image-webgl.html canvas/philip/tests/2d.pattern.paint.orientation.canvas.html fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.modify.canvas1.html http/tests/inspector/inspect-element.html fast/canvas/webgl/texture-npot.html canvas/philip/tests/initial.reset.pattern.html webgl/conformance/textures/gl-teximage.html webgl/conformance/context/premultiplyalpha-test.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html editing/pasteboard/copy-image-with-alt-text.html canvas/philip/tests/2d.pattern.basic.canvas.html webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html fast/canvas/webgl/tex-sub-image-2d-bad-args.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html fast/canvas/webgl/premultiplyalpha-test.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html fast/canvas/webgl/texture-active-bind.html fast/canvas/webgl/canvas-2d-webgl-texture.html

Build Bot

Comment 28 2013-07-22 03:58:08 PDT

Created attachment 207238 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Build Bot

Comment 29 2013-07-22 20:19:25 PDT

Comment on attachment 207181 [details] WIP-8 Attachment 207181 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1139261

Build Bot

Comment 30 2013-07-31 16:40:38 PDT

Comment on attachment 207181 [details] WIP-8 Attachment 207181 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1289908 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html fast/canvas/pattern-with-transform.html fast/canvas/canvas-pattern-modify.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html fast/canvas/webgl/tex-sub-image-2d-bad-args.html canvas/philip/tests/initial.reset.pattern.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html canvas/philip/tests/2d.pattern.modify.canvas2.html fast/css/font-face-data-uri.html fast/canvas/webgl/tex-image-webgl.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html fast/canvas/webgl/canvas-2d-webgl-texture.html canvas/philip/tests/2d.pattern.paint.orientation.canvas.html fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.modify.canvas1.html canvas/philip/tests/2d.pattern.basic.canvas.html http/tests/inspector/inspect-element.html

Build Bot

Comment 31 2013-07-31 16:40:42 PDT

Created attachment 207884 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Michael Catanzaro

Comment 32 2017-03-11 10:37:21 PST

Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

Note You need to log in before you can comment on or make changes to this bug.