Bug 119491

Summary: [CSS Shapes] New positioning model: scripted shape-margin tests
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
achicu: review+
Patch none

Bem Jones-Bey
Reported 2013-08-05 11:59:51 PDT
Update the shape-margin script tests to work with the new positioning model. They are the following tests: shape-outside-floats-diamond-margin-polygon.html shape-outside-floats-ellipse-margin-bottom.html (strictly speaking not a script test, but including it here anyways) shape-outside-floats-ellipse-margin-left.html shape-outside-floats-ellipse-margin-right.html
Attachments
Patch (7.26 KB, patch)
2013-08-06 08:40 PDT, Hans Muller 		achicu: review+
DetailsFormatted DiffDiff
Patch (7.36 KB, patch)
2013-08-06 13:57 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-08-06 08:40:21 PDT
Created attachment 208193 [details] Patch Update some of the shape-margin tests to work with the new positioning model. Floats that specify shape-outside are now positioned according to their margin box, not the bounding box of the shape-outside shape. The tests have been revised to reflect the change.
Alexandru Chiculita
Comment 2 2013-08-06 11:23:11 PDT
Comment on attachment 208193 [details] Patch r=me
Hans Muller
Comment 3 2013-08-06 13:57:23 PDT
Created attachment 208217 [details] Patch
WebKit Commit Bot
Comment 4 2013-08-06 15:15:08 PDT
Comment on attachment 208217 [details] Patch Clearing flags on attachment: 208217 Committed r153769: <http://trac.webkit.org/changeset/153769>
WebKit Commit Bot
Comment 5 2013-08-06 15:15:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.