Bug 120685

Created attachment 210464 [details] for bots

Attachment 210464 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFrameElementBase.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/shadow/InsertionPoint.cpp', u'Source/WebCore/loader/PlaceholderDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/testing/Internals.cpp']" exit_code: 1 Source/WebCore/dom/ContainerNode.cpp:1071: One space before end of line comments [whitespace/comments] [5] Source/WebCore/testing/Internals.cpp:498: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 210464 [details] for bots Attachment 210464 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1694696 New failing tests: editing/text-iterator/range-to-from-location-and-length.html editing/selection/caret-ltr-right.html css3/selectors3/xml/css3-modsel-147b.xml css3/selectors3/xml/css3-modsel-24.xml css3/selectors3/xml/css3-modsel-34.xml css3/selectors3/xml/css3-modsel-d3.xml css3/selectors3/xml/css3-modsel-145b.xml css3/selectors3/xml/css3-modsel-146b.xml editing/input/reveal-caret-of-multiline-input.html http/tests/inspector/inspect-element.html css3/selectors3/xml/css3-modsel-36.xml editing/style/toggle-style-bold-italic.html css3/selectors3/xml/css3-modsel-79.xml editing/selection/caret-rtl-2-left.html css3/selectors3/xml/css3-modsel-81b.xml editing/selection/caret-ltr-2-left.html css3/selectors3/xml/css3-modsel-23.xml css3/selectors3/xml/css3-modsel-146a.xml editing/style/toggle-style-bold-italic-mixed-editability.html css3/selectors3/xml/css3-modsel-145a.xml fast/block/block-remove-child-delete-line-box-crash.html http/tests/inspector/network/network-initiator.html css3/selectors3/xml/css3-modsel-147a.xml css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xml/css3-modsel-69.xml css3/selectors3/xml/css3-modsel-81.xml css2.1/t060401-c32-cascading-00-b.html css3/calc/transitions-dependent.html editing/selection/caret-ltr.html editing/selection/caret-ltr-2.html

Created attachment 210504 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Created attachment 210619 [details] for bots 2

Attachment 210619 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFrameElementBase.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/shadow/InsertionPoint.cpp', u'Source/WebCore/loader/PlaceholderDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/testing/Internals.cpp']" exit_code: 1 Source/WebCore/dom/ContainerNode.cpp:1071: One space before end of line comments [whitespace/comments] [5] Source/WebCore/testing/Internals.cpp:498: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 210664 [details] for bots 3

Comment on attachment 210664 [details] for bots 3 Attachment 210664 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1706232

Comment on attachment 210664 [details] for bots 3 Attachment 210664 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1719036 New failing tests: http/tests/misc/empty-urls.html fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html fast/body-propagation/background-color/003-xhtml.xhtml editing/style/toggle-style-bold-italic-mixed-editability.html css3/calc/transitions-dependent.html fast/dynamic/011.html fast/forms/autofocus-in-sandbox-with-allow-scripts.html fast/forms/radio/radio_checked_dynamic.html fast/forms/basic-textareas-quirks.html editing/style/toggle-style-bold-italic.html fast/events/key-events-in-input-text.html http/tests/inspector/network/network-initiator.html fast/css-generated-content/before-content-continuation-chain.html http/tests/inspector/inspect-element.html

Created attachment 210785 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Comment on attachment 210664 [details] for bots 3 Attachment 210664 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1719185

We might need https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952

Also https://chromium.googlesource.com/chromium/blink/+/f54545c09cf48bc7ba2413b3abf5ba8b98a69dcf

Related https://chromium.googlesource.com/chromium/blink/+/0846ba13f76cbef958efa46cf9a44403c7c9d97a

And https://chromium.googlesource.com/chromium/blink/+/37a04dec847157bafee796ba96a2980a4692e939

Created attachment 219089 [details] another

Comment on attachment 219089 [details] another Attachment 219089 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/48248016

Comment on attachment 219089 [details] another Attachment 219089 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/48498030

Comment on attachment 219089 [details] another Attachment 219089 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47178247 New failing tests: fullscreen/full-screen-render-inline.html tables/mozilla/other/wa_table_tr_align.html editing/pasteboard/paste-into-textarea-with-new-line.html platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html transitions/transition-duration-cleared-in-transitionend-crash.html fast/forms/input-text-self-emptying-click.html scrollbars/scrollbar-miss-mousemove-disabled.html transitions/repeated-firing-background-color.html tables/mozilla/bugs/bug113235-1.html fast/images/imagemap-case.html fast/forms/input-text-drag-down.html plugins/object-onfocus-mutation-crash.html fast/forms/input-text-double-click.html printing/single-line-must-not-be-split-into-two-pages.html fast/events/scrollbar-double-click.html transitions/equivalent-background-image-no-transition.html fast/forms/input-text-click-inside.html plugins/clicking-missing-plugin-fires-delegate.html fast/regions/cssom/webkit-named-flow-get-content.html fast/forms/textarea-type-spaces.html platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html plugins/plugin-remove-readystatechange.html tables/mozilla/bugs/bug647.html editing/selection/contenteditable-click-inside.html fast/forms/input-text-click-outside.html fast/events/key-events-in-input-text.html fast/dom/HTMLTableColElement/resize-table-using-col-width.html

Created attachment 219231 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 219089 [details] another Attachment 219089 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/49088051 New failing tests: fullscreen/full-screen-render-inline.html tables/mozilla/other/wa_table_tr_align.html editing/pasteboard/paste-into-textarea-with-new-line.html platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html transitions/transition-duration-cleared-in-transitionend-crash.html fast/forms/input-text-self-emptying-click.html scrollbars/scrollbar-miss-mousemove-disabled.html transitions/repeated-firing-background-color.html tables/mozilla/bugs/bug113235-1.html fast/images/imagemap-case.html fast/forms/input-text-drag-down.html plugins/object-onfocus-mutation-crash.html fast/forms/input-text-double-click.html printing/single-line-must-not-be-split-into-two-pages.html fast/events/scrollbar-double-click.html transitions/equivalent-background-image-no-transition.html fast/forms/input-text-click-inside.html plugins/clicking-missing-plugin-fires-delegate.html fast/regions/cssom/webkit-named-flow-get-content.html fast/forms/textarea-type-spaces.html platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html plugins/plugin-remove-readystatechange.html tables/mozilla/bugs/bug647.html editing/selection/contenteditable-click-inside.html fast/forms/input-text-click-outside.html fast/events/key-events-in-input-text.html fast/dom/HTMLTableColElement/resize-table-using-col-width.html

Created attachment 219239 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 219652 [details] yet another

Comment on attachment 219652 [details] yet another Attachment 219652 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/48938651

Comment on attachment 219652 [details] yet another Attachment 219652 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/48688293 New failing tests: fullscreen/full-screen-render-inline.html

Created attachment 219656 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 219652 [details] yet another Attachment 219652 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47778032 New failing tests: fullscreen/full-screen-render-inline.html

Created attachment 219669 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 219701 [details] patch

Comment on attachment 219701 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=219701&action=review r=me! > Source/WebCore/ChangeLog:100 > + TextControlInnerTextElement always preserveres newline even if it doesn't have style yet. Typo, preserves. > Source/WebCore/dom/Element.cpp:2938 > + auto children = elementDescendants(*this); > + for (auto it = children.begin(), end = children.end(); it != end; ++it) { Should use range for syntax here. > Source/WebCore/dom/Node.cpp:2302 > + // FIXME: This should go away alonw with the whole vague 'attached' concept. The conditions here produce > + // roughly the old behavior based on an explicit attached bit. Typo, along. > Source/WebCore/html/HTMLElement.cpp:666 > bool HTMLElement::supportsFocus() const > { > + if (!document().view()->isInLayout()) > + document().updateStyleIfNeeded(); I guess this function can be called during layout? > Source/WebCore/html/HTMLFormControlElement.cpp:171 > static bool shouldAutofocus(HTMLFormControlElement* element) Urgh, raw pointer. How tacky. > Source/WebCore/loader/PlaceholderDocument.cpp:40 > - setAttached(true); > +// setAttached(true); Busted!

antti++

Comment on attachment 219701 [details] patch Attachment 219701 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/50208137 New failing tests: fast/preloader/input.html fast/preloader/noscript.html fast/preloader/image.html fast/preloader/first-base-tag-scanned-wins.html fast/preloader/first-base-tag-wins.html fast/preloader/understands-base-tag.html

Created attachment 219721 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 219701 [details] patch Attachment 219701 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/47778128

Comment on attachment 219701 [details] patch Attachment 219701 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46678113 New failing tests: fast/preloader/input.html fast/preloader/noscript.html fast/preloader/image.html fast/preloader/first-base-tag-scanned-wins.html fast/preloader/first-base-tag-wins.html fast/preloader/understands-base-tag.html

Created attachment 219724 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 219701 [details] patch Attachment 219701 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/50938128 New failing tests: fast/preloader/input.html fast/preloader/noscript.html svg/batik/filters/filterRegions.svg fast/preloader/first-base-tag-scanned-wins.html fast/preloader/first-base-tag-wins.html fast/preloader/understands-base-tag.html fast/preloader/image.html

Created attachment 219728 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

https://trac.webkit.org/r160908 (with preloading fixed)

(In reply to comment #39) > https://trac.webkit.org/r160908 > > (with preloading fixed) FYI: It broke the Windows build - http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/55846

This caused a regression on forward referencing to a SVG resource <filter>.

(In reply to comment #41) > This caused a regression on forward referencing to a SVG resource <filter>. Filed as Bug 126976. I don't think there is any purpose served by leaving this bug open at this point.

Fixes (CVE-2014-4413, CVE-2014-4414).