Bug 120875

Summary: MediaStream API: Remove LocalMediaStream
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, luciano.wolf, philn, rakuco, rniwa, tommyw, xan.lopez
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Eric Carlson
Reported 2013-09-06 11:50:45 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/81643ee3fe048a64fa8931132e1294fa2c8e821a The subclass LocalMediaStream have been removed from the getusermedia specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html The stop method will be moved temporarily to MediaStream until MediaStreamTrack has been updated.
Attachments
Patch (25.47 KB, patch)
2013-09-10 20:15 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch (36.40 KB, patch)
2013-09-11 11:31 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch (36.10 KB, patch)
2013-09-11 14:56 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-09-10 20:15:55 PDT
Created attachment 211275 [details] Patch
Build Bot
Comment 2 2013-09-10 20:40:16 PDT
Comment on attachment 211275 [details] Patch Attachment 211275 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1736748
Build Bot
Comment 3 2013-09-10 20:58:11 PDT
Comment on attachment 211275 [details] Patch Attachment 211275 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1731829
kov's GTK+ EWS bot
Comment 4 2013-09-10 23:59:17 PDT
Comment on attachment 211275 [details] Patch Attachment 211275 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1743456
Thiago de Barros Lacerda
Comment 5 2013-09-11 11:31:24 PDT
Created attachment 211334 [details] Patch
Eric Carlson
Comment 6 2013-09-11 13:51:58 PDT
Comment on attachment 211334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211334&action=review r=me with the changes noted. > Source/WebCore/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=120875 > + > + Reviewed by NOBODY (OOPS!). > + > + Existing tests were updated. This should reference the Blink change this was merged from. > Source/WebCore/Modules/mediastream/MediaStream.h:-53 > - // DEPRECATED > - String label() const { return m_descriptor->id(); } > - This is unrelated, it should be removed in another patch. > Source/WebCore/Modules/mediastream/MediaStream.idl:-37 > - // DEPRECATED > - readonly attribute DOMString label; > - Ditto
Thiago de Barros Lacerda
Comment 7 2013-09-11 14:56:13 PDT
Created attachment 211356 [details] Patch
WebKit Commit Bot
Comment 8 2013-09-11 15:31:29 PDT
Comment on attachment 211356 [details] Patch Clearing flags on attachment: 211356 Committed r155573: <http://trac.webkit.org/changeset/155573>
Note You need to log in before you can comment on or make changes to this bug.