Bug 120879

Summary: Make MediaStream objects ScriptWrappable
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, oliver, sam, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-09-06 11:59:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/621822b20d5b0ceceb000b3c02ae82cce5063c51 This change allows binding intergrity checks to be applied to these obects.
Attachments
Proposed patch (9.34 KB, patch)
2013-09-10 14:12 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-09-10 14:12:47 PDT
Created attachment 211241 [details] Proposed patch
Jer Noble
Comment 2 2013-09-10 14:15:26 PDT
Comment on attachment 211241 [details] Proposed patch LGTM. r=me.
Sam Weinig
Comment 3 2013-09-10 14:21:46 PDT
I'm not against this change, but I don't follow the reasoning. What about making them ScriptWrappable helps with the integrity checks. I think the only thing needed for those checks is a vtable.
Sam Weinig
Comment 4 2013-09-10 14:22:23 PDT
I'd like Oliver to comment before landing.
Oliver Hunt
Comment 5 2013-09-10 14:25:30 PDT
Looks good
WebKit Commit Bot
Comment 6 2013-09-10 14:47:37 PDT
Comment on attachment 211241 [details] Proposed patch Clearing flags on attachment: 211241 Committed r155478: <http://trac.webkit.org/changeset/155478>
WebKit Commit Bot
Comment 7 2013-09-10 14:47:39 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 8 2013-09-10 15:11:36 PDT
(In reply to comment #5) > Looks good Oliver, what about making them ScriptWrappable helps with the integrity checks?
Eric Carlson
Comment 9 2013-09-11 09:20:54 PDT
(In reply to comment #8) > (In reply to comment #5) > > Looks good > > Oliver, what about making them ScriptWrappable helps with the integrity checks? I talked to Geoff about this patch before I posted it. He said that with JSC it won't help with "binding integrity checks", but that it I might as well merge it to make future merges easier. The "This change allows binding intergrity checks to be applied to these obects" comment is from the blink bug. I didn't include it in the ChangeLog.
Note You need to log in before you can comment on or make changes to this bug.