Bug 120889

Summary: MediaStream API: Update RTCDataChannel to match the specification
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, syoichi, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Patch
none
Patch none

Eric Carlson
Reported 2013-09-06 13:08:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/c3862b0a83e20fc8b1f770c7e4a886a7cceb80d2 Just adding a bunch of attributes and deprecating one.
Attachments
Patch (5.05 KB, patch)
2013-09-14 15:50 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch (5.05 KB, patch)
2013-09-14 15:52 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-09-14 15:50:17 PDT
Created attachment 211670 [details] Patch
Thiago de Barros Lacerda
Comment 2 2013-09-14 15:52:03 PDT
Created attachment 211671 [details] Patch
Eric Carlson
Comment 3 2013-09-14 16:13:49 PDT
Comment on attachment 211671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review > Source/WebCore/ChangeLog:19 > + According to WebRTC specification, RTCDataChannel must have the following new attributes: > + boolean ordered > + unsigned short maxRetransmitTime > + unsigned short maxRetransmits > + DOMString protocol > + boolean negotiated > + unsigned short id > + > + and the following one was deprecated: > + boolean reliable > + > + No new tests needed. Please not the blink revision this was merged from.
Eric Carlson
Comment 4 2013-09-14 16:14:13 PDT
(In reply to comment #3) > (From update of attachment 211671 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review > > > Source/WebCore/ChangeLog:19 > > + According to WebRTC specification, RTCDataChannel must have the following new attributes: > > + boolean ordered > > + unsigned short maxRetransmitTime > > + unsigned short maxRetransmits > > + DOMString protocol > > + boolean negotiated > > + unsigned short id > > + > > + and the following one was deprecated: > > + boolean reliable > > + > > + No new tests needed. > > Please not the blink revision this was merged from. Please *note* the revision.
Eric Carlson
Comment 5 2013-09-14 16:31:20 PDT
Comment on attachment 211671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review >>> Source/WebCore/ChangeLog:19 >>> + No new tests needed. >> >> Please not the blink revision this was merged from. > > Please *note* the revision. I will update RTCPeerConnection-datachannel.html with bug 121102.
Eric Carlson
Comment 6 2013-09-14 17:16:09 PDT
I will land this.
Eric Carlson
Comment 7 2013-09-14 17:52:06 PDT
Committed in r155792: : https://trac.webkit.org/r155792
Note You need to log in before you can comment on or make changes to this bug.