Bug 120994

Summary: run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 120696, 120996    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2013-09-07 21:02:11 PDT
run-jsc-stress-tests accepts a list of directories containing tests. It needs to come up with names for all of them. Currently it uses the basename of the test directory. But that means that JSRegress gets called "script-tests", which is unfortunate since any directory in LayoutTests containing .js files will be called "script-tests". So, we should change run-jsc-stress-tests to use more than just the basename if the basename has the word "tests" in it. This will cause JSRegress to be called "regress/script-tests".
Attachments
the patch (2.65 KB, patch)
2013-09-07 21:04 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-07 21:04:03 PDT
Created attachment 210958 [details] the patch
Geoffrey Garen
Comment 2 2013-09-08 10:12:18 PDT
Comment on attachment 210958 [details] the patch r=me
Filip Pizlo
Comment 3 2013-09-08 13:12:47 PDT
Landed in http://trac.webkit.org/changeset/155305
Note You need to log in before you can comment on or make changes to this bug.