Bug 121589

Summary: Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, dino, dstockwell, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, simon.fraser, thorton
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Fixed indentation style dino: review+

Ryosuke Niwa
Reported 2013-09-18 21:53:25 PDT
Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
Attachments
Cleanup (12.24 KB, patch)
2013-09-18 21:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed indentation style (10.05 KB, patch)
2013-09-19 14:50 PDT, Ryosuke Niwa 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-09-18 21:54:56 PDT
Created attachment 212035 [details] Cleanup
Simon Fraser (smfr)
Comment 2 2013-09-19 14:41:10 PDT
Comment on attachment 212035 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=212035&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1253 > + { > + const StepsTimingFunction* stepsTimingFunction = static_cast<const StepsTimingFunction*>(timingFunction); > + return CSSStepsTimingFunctionValue::create(stepsTimingFunction->numberOfSteps(), stepsTimingFunction->stepAtStart()); > + } This doesn't match our indentation style. > Source/WebCore/page/animation/AnimationBase.cpp:605 > + { > + const CubicBezierTimingFunction* function = static_cast<const CubicBezierTimingFunction*>(tf); > + return solveCubicBezierFunction(function->x1(), function->y1(), function->x2(), function->y2(), fractionalTime, m_animation->duration()); > + } > + case TimingFunction::StepsFunction: > + { > + const StepsTimingFunction* stepsTimingFunction = static_cast<const StepsTimingFunction*>(tf); > + return solveStepsFunction(stepsTimingFunction->numberOfSteps(), stepsTimingFunction->stepAtStart(), fractionalTime); > + } Ditto.
Ryosuke Niwa
Comment 3 2013-09-19 14:50:14 PDT
Created attachment 212102 [details] Fixed indentation style
Ryosuke Niwa
Comment 4 2013-09-19 15:37:12 PDT
Committed r156125: <http://trac.webkit.org/changeset/156125>
Note You need to log in before you can comment on or make changes to this bug.