Bug 121808

Summary: Properly handle bottom margin on float with shape-outside
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118089    
Attachments:
Description Flags
Patch
none
Fix review feedback
none
Rebase none

Bem Jones-Bey
Reported 2013-09-23 15:38:09 PDT
Properly handle bottom margin on float with shape-outside
Attachments
Patch (14.07 KB, patch)
2013-09-23 15:40 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Fix review feedback (20.45 KB, patch)
2013-09-24 10:44 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Rebase (20.40 KB, patch)
2013-09-24 11:27 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-09-23 15:40:59 PDT
Created attachment 212400 [details] Patch
Dave Hyatt
Comment 2 2013-09-24 09:39:16 PDT
Comment on attachment 212400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212400&action=review > Source/WebCore/rendering/RenderBlock.cpp:3754 > + floatBottom = r->y() + marginBeforeForChild(r->renderer()) + shapeOutside->shapeLogicalBottom(); y() is wrong here. Let's get a vertical test, which will show why it's wrong. :)
Bem Jones-Bey
Comment 3 2013-09-24 10:44:29 PDT
Created attachment 212480 [details] Fix review feedback Duh. Yeah, I should have been using logical coordinates. FIxed, and one more test added.
Dave Hyatt
Comment 4 2013-09-24 11:16:29 PDT
Comment on attachment 212480 [details] Fix review feedback r=me
Bem Jones-Bey
Comment 5 2013-09-24 11:27:29 PDT
Created attachment 212484 [details] Rebase
WebKit Commit Bot
Comment 6 2013-09-24 12:01:49 PDT
Comment on attachment 212484 [details] Rebase Clearing flags on attachment: 212484 Committed r156346: <http://trac.webkit.org/changeset/156346>
WebKit Commit Bot
Comment 7 2013-09-24 12:01:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.