Bug 122216

Summary:

[CSS Shapes] Implement the shape-image-threshold property

Product:

WebKit

Reporter:

Hans Muller <giles_joplin>

Component:

CSS

Assignee:

Hans Muller <giles_joplin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, esprehn+autocc, glenn, kondapallykalyan, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

116348, 122254

Attachments:

Description	Flags
Patch	none

Hans Muller

Reported 2013-10-02 09:34:04 PDT

The current Shapes implementation, notably Shape::createShape(const StyleImage* styleImage, ...), always uses 0 for this threshold.

Attachments
Patch (12.82 KB, patch) 2013-10-02 16:03 PDT, Hans Muller	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hans Muller

Comment 1 2013-10-02 16:03:27 PDT

Created attachment 213211 [details] Patch Added support for the CSS shape-image-threshold property. This change just enables parsing the property, it's not connected to the Shapes code yet. The number valued shape-image-threshold property is defined here: http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property. Its computed value is clamped to the range [0, 1].

Andreas Kling

Comment 2 2013-10-02 17:05:15 PDT

Comment on attachment 213211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213211&action=review You didn't mark this patch r?, but it looks good to me. > LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold.html:8 > +<script src="script-tests/parsing-shape-image-threshold.js"></script> It seems silly to have the test logic in a separate file. make-new-script-tests generates a single HTML file with everything these days.

Andreas Kling

Comment 3 2013-10-02 17:12:42 PDT

Comment on attachment 213211 [details] Patch r=me

Hans Muller

Comment 4 2013-10-02 17:28:06 PDT

(In reply to comment #2) > (From update of attachment 213211 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213211&action=review > > LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold.html:8 > > +<script src="script-tests/parsing-shape-image-threshold.js"></script> > > It seems silly to have the test logic in a separate file. > make-new-script-tests generates a single HTML file with everything these days. Will make this change in a separate patch: https://bugs.webkit.org/show_bug.cgi?id=122251

WebKit Commit Bot

Comment 5 2013-10-02 17:53:15 PDT

Comment on attachment 213211 [details] Patch Clearing flags on attachment: 213211 Committed r156814: <http://trac.webkit.org/changeset/156814>

WebKit Commit Bot

Comment 6 2013-10-02 17:53:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.