Bug 122254

Summary: [CSS Shapes] Support the shape-image-threshold property
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 122216    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-10-02 18:20:19 PDT
Make the Shape class use the value of the shape-image-threshold property. The spec for this property is http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Attachments
Patch (7.49 KB, patch)
2013-10-03 08:36 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-10-03 08:36:00 PDT
Created attachment 213250 [details] Patch Replace the hardwired 0 Shape::createShape() threshold parameter with the style's shapeImageThreshold() value (which has been clamped to [0,1]).
Andreas Kling
Comment 2 2013-10-03 12:38:55 PDT
Comment on attachment 213250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213250&action=review r=me > Source/WebCore/rendering/shapes/ShapeInfo.cpp:62 > - m_shape = Shape::createShape(shapeValue->image(), 0, m_shapeLogicalSize, writingMode, margin, padding); > + m_shape = Shape::createShape(shapeValue->image(), shapeImageThreshold, m_shapeLogicalSize, writingMode, margin, padding); Maybe Shape::createShape() should ASSERT that shapeImageThreshold is between 0 and 1?
WebKit Commit Bot
Comment 3 2013-10-03 13:03:28 PDT
Comment on attachment 213250 [details] Patch Clearing flags on attachment: 213250 Committed r156852: <http://trac.webkit.org/changeset/156852>
WebKit Commit Bot
Comment 4 2013-10-03 13:03:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.