Bug 122972

Summary: Don't add an include for return type of a [Custom] function in generated bindings code
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore JavaScriptAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, mhahnenberg, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122679    
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2013-10-17 10:30:32 PDT
Custom functions are not implemented in generated files, so there is no reason to include headers for their types. We already have this behavior for their argument types. This is a minor roadblock for WebCrypto, where I have custom functions that return promises, but no matching headers for promise types. And a desirable behavior in any case, I think.
Attachments
proposed patch (1.72 KB, patch)
2013-10-17 10:32 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-17 10:32:05 PDT
Created attachment 214470 [details] proposed patch
WebKit Commit Bot
Comment 2 2013-10-17 17:51:17 PDT
Comment on attachment 214470 [details] proposed patch Clearing flags on attachment: 214470 Committed r157615: <http://trac.webkit.org/changeset/157615>
WebKit Commit Bot
Comment 3 2013-10-17 17:51:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.