Bug 123225

Summary: Add a timeline object and reference it from Document
Product: WebKit Reporter: Dean Jackson <dino>
Component: AnimationsAssignee: Dean Jackson <dino>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: andrew, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, kangil.han, krit, philn, rakuco, rawinder.webkit, webkit-bug-importer, xan.lopez, zan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122912    
Attachments:
Description Flags
Patch
none
Patch buildbot: commit-queue-

Dean Jackson
Reported 2013-10-23 15:28:56 PDT
Implement a Timeline class. http://dev.w3.org/fxtf/web-animations/#dfn-timeline http://dev.w3.org/fxtf/web-animations/#the-timeline-interface Note, this will not expose the API. To begin with there will be a single instance referenced from Document, and it will have a monotonically increasing time.
Attachments
Patch (14.88 KB, patch)
2013-10-24 16:28 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (15.49 KB, patch)
2013-10-24 16:55 PDT, Dean Jackson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-10-23 15:44:10 PDT
<rdar://problem/15303866>
Dean Jackson
Comment 2 2013-10-24 16:28:22 PDT
Created attachment 215119 [details] Patch
Dean Jackson
Comment 3 2013-10-24 16:55:40 PDT
Created attachment 215122 [details] Patch
Anders Carlsson
Comment 4 2013-10-24 17:22:51 PDT
Comment on attachment 215122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215122&action=review > Source/WebCore/animation/Timeline.h:35 > +class Timeline : public RefCounted<Timeline> { > +public: Does this really need to be refcounted? > Source/WebCore/dom/Document.h:1187 > + Timeline* timeline() const { return m_timeline.get(); } This should return a reference since it can never be null.
Dean Jackson
Comment 5 2013-10-24 17:24:02 PDT
Comment on attachment 215122 [details] Patch No longer for review. Will work on this more offline before choosing a design.
Build Bot
Comment 6 2013-10-24 17:42:05 PDT
Comment on attachment 215122 [details] Patch Attachment 215122 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/10308204
Rawinder Singh
Comment 7 2016-04-04 23:19:21 PDT
*** This bug has been marked as a duplicate of bug 151688 ***
Note You need to log in before you can comment on or make changes to this bug.