Bug 124138
| Summary: | regress/script-tests/make-indexed-storage.js.ftl-eager-no-cjit: Exception: Error: bad result: NaN | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 124137, 124169, 124171, 124181 | ||
| Bug Blocks: | 112840 | ||
Filip Pizlo
Will fix it soon.
This is revealed by the fix to https://bugs.webkit.org/show_bug.cgi?id=124137
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Filip Pizlo
OK, I think this is fixed, as of http://trac.webkit.org/changeset/159394.
The problem was that we were constant-folding a variable but only along one control flow path, which was resulting in its live range appearing to be truncated.
This was ultimately solved by ensuring that liveness in the original bytecode, rather than liveness in the DFG IR after optimization, determines whether or not a variable is preserved by OSR.